Issue open-horizon#4156 - Bug: On restart, agbot doesn't update a nod… #4157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dlarson04
requested changes
Oct 8, 2024
agreementbot/agreementbot.go
Outdated
| @@ -1119,6 +1122,51 @@ func (w *AgreementBotWorker) syncOnInit() error { | |||
| glog.V(3).Infof(AWlogString(fmt.Sprintf("added agreement %v to policy agreement counter.", ag.CurrentAgreementId))) | |||
| } | |||
|
|
|||
| // After checking the pol userdev/bp_netspeed, add it in to a map. In Each for loop which iterate the agreements, checking if current policy inside agreement has been handled or not | |||
There was a problem hiding this comment.
You should remove the userdev/bp_netspeed comment
agreementbot/agreementbot.go
Outdated
| glog.Errorf(fmt.Sprintf("Error trying to marshal internal business policy %v error: %v", exPolicy, err)) | ||
| } else { | ||
| // If business policy has been changed during a restart, handle it | ||
| glog.V(3).Infof(AWlogString(fmt.Sprintf("policy(%v) in agreement %v has been changed", pol.Header.Name, ag.CurrentAgreementId))) |
There was a problem hiding this comment.
I don't think this log message is correct... At this point, we don't know that the policy has been changed... we just want the agbot to re-evaluate the policy just in case it changed.
LiilyZhang
force-pushed
the
zhangl/Issue4156
branch
5 times, most recently
from
72f0838
to
c4aae65
Compare
dlarson04
requested changes
Oct 9, 2024
agreementbot/agreementbot.go
Outdated
| @@ -1142,6 +1179,11 @@ func (w *AgreementBotWorker) syncOnInit() error { | |||
| } | |||
| } | |||
|
|
|||
| glog.V(3).Infof(AWlogString(fmt.Sprintf("discovered changed/deleted business policies: %v", bPolicyMessageMap))) | |||
There was a problem hiding this comment.
I would not say "changed" policies in the log message.... Deleted is ok but maybe "policies that might have changed"
…e even though a new service was added and a deployment policy update occurred Signed-off-by: Le Zhang <zhangl@us.ibm.com>
LiilyZhang
force-pushed
the
zhangl/Issue4156
branch
from
c4aae65
to
f8c2500
Compare
|
Built and tested this in the all-in-one environment.. After restart, all the agents got the service update. |
dlarson04
approved these changes
Oct 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…e even though a new service was added and a deployment policy update occurred
Pull Request Template
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes # (issue)
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Additional Context (Please include any Screenshots/gifs if relevant)
...
Checklist: