Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flat hand mean #301

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

pangyyyyy
Copy link
Collaborator

flat_hand_mean flag is not working in SMPLXlayer and MANOlayer

@pangyyyyy pangyyyyy requested a review from caizhongang January 15, 2023 06:18
@codecov
Copy link

codecov bot commented Jan 15, 2023

Codecov Report

Base: 84.91% // Head: 84.93% // Increases project coverage by +0.02% 🎉

Coverage data is based on head (db3507b) compared to base (32fb6c7).
Patch coverage: 26.66% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #301      +/-   ##
==========================================
+ Coverage   84.91%   84.93%   +0.02%     
==========================================
  Files         200      200              
  Lines       17570    17618      +48     
==========================================
+ Hits        14919    14964      +45     
- Misses       2651     2654       +3     
Flag Coverage Δ
unittests 84.93% <26.66%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
mmhuman3d/models/body_models/mano.py 26.96% <16.66%> (-0.75%) ⬇️
mmhuman3d/models/body_models/smplx.py 83.33% <33.33%> (-3.39%) ⬇️
mmhuman3d/models/body_models/star.py 100.00% <0.00%> (ø)
mmhuman3d/core/renderer/matplotlib3d_renderer.py 100.00% <0.00%> (ø)
...uman3d/data/data_converters/mpi_inf_3dhp_hybrik.py 99.09% <0.00%> (+<0.01%) ⬆️
mmhuman3d/data/data_structures/human_data.py 98.74% <0.00%> (+0.03%) ⬆️
mmhuman3d/data/data_converters/penn_action.py 98.11% <0.00%> (+0.03%) ⬆️
mmhuman3d/data/data_converters/eft.py 97.05% <0.00%> (+0.04%) ⬆️
.../models/architectures/expressive_mesh_estimator.py 78.06% <0.00%> (+0.04%) ⬆️
mmhuman3d/data/datasets/human_image_dataset.py 76.05% <0.00%> (+0.06%) ⬆️
... and 8 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant