Topic/fix ob1 segmentation with UCT BTL #12823
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: George Bosilca <gbosilca@nvidia.com>
hjelmn
approved these changes
Sep 24, 2024
Return the updated amount to allow the upper level to gracefully handle the case. Signed-off-by: George Bosilca <gbosilca@nvidia.com>
Signed-off-by: George Bosilca <gbosilca@nvidia.com>
bosilca
force-pushed
the
topic/fix_ob1_segmentation
branch
from
d782fdb
to
58400ad
Compare
bosilca
added
Target: v5.0.x
Target: v6.0.x
Target: v4.1.x
and removed
Target: v4.1.x
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses the two issues resulting from the discussions on #12698. First, it allows the UCT BTL to pack less data than expected, and to return the packed amount to correctly update the request. Second, it should fix the case where data was shifted in the buffer during the pack.
Many thanks to @ggouaillardet and @AnnaLena77 for the discussion and help.
Fixes #12698