Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update opal_portable_platform_real.h from upstream gasnet #12829

Merged
merged 1 commit into from
Sep 28, 2024

Commits on Sep 28, 2024

  1. Update opal_portable_platform_real.h from upstream gasnet

    Pull update from
    https://bitbucket.org/berkeleylab/gasnet/src/stable/other/gasnet_portable_platform.h
    at git hash a90966674.  This update brings in two things:
    
    1. Remove the need for the #define workarounds in
       opal/include/opal/opal_portable_platform.h
    2. Remove all //-style comments, making this file safe to use with
       C89-style applications (per
       open-mpi#12710).
    
    Many thanks to the gasnet team for including these changes in their
    upstream repo.
    
    Note that we still need the #ifndef SIZEOF_VOID_P protection in mpi.h.
    This commit also makes a minor update in mpi.h[.in] to prefix an
    OMPI-specific #define with "OMPI_".  No one has ever complained about
    this un-prefixed macro, but prefixing it it felt like the Right Thing
    to do while mucking around with other portable_platform stuff.
    
    Signed-off-by: Jeff Squyres <jeff@squyres.com>
    jsquyres committed Sep 28, 2024
    Configuration menu
    Copy the full SHA
    50c05da View commit details
    Browse the repository at this point in the history