From d5845988378e6e1c2851a5e1ed82defbaeea976a Mon Sep 17 00:00:00 2001 From: Jaydip Gabani Date: Thu, 19 Sep 2024 20:55:13 +0000 Subject: [PATCH] fixing CEL error Signed-off-by: Jaydip Gabani --- .../1.1.2/artifacthub-pkg.yml | 22 +++ .../1.1.2/kustomization.yaml | 2 + .../psp-privileged-container/constraint.yaml | 13 ++ .../disallowed_ephemeral.yaml | 12 ++ .../example_allowed.yaml | 12 ++ .../example_allowed_exempt.yaml | 12 ++ .../example_disallowed.yaml | 17 +++ .../psp-privileged-container/update.yaml | 17 +++ .../privileged-containers/1.1.2/suite.yaml | 29 ++++ .../privileged-containers/1.1.2/template.yaml | 129 ++++++++++++++++++ .../example_disallowed.yaml | 5 + .../privileged-containers/template.yaml | 8 +- .../privileged-containers/constraint.tmpl | 2 +- .../privileged-containers/src.cel | 6 +- .../docs/validation/privileged-containers.md | 13 +- 15 files changed, 287 insertions(+), 12 deletions(-) create mode 100644 artifacthub/library/pod-security-policy/privileged-containers/1.1.2/artifacthub-pkg.yml create mode 100644 artifacthub/library/pod-security-policy/privileged-containers/1.1.2/kustomization.yaml create mode 100644 artifacthub/library/pod-security-policy/privileged-containers/1.1.2/samples/psp-privileged-container/constraint.yaml create mode 100644 artifacthub/library/pod-security-policy/privileged-containers/1.1.2/samples/psp-privileged-container/disallowed_ephemeral.yaml create mode 100644 artifacthub/library/pod-security-policy/privileged-containers/1.1.2/samples/psp-privileged-container/example_allowed.yaml create mode 100644 artifacthub/library/pod-security-policy/privileged-containers/1.1.2/samples/psp-privileged-container/example_allowed_exempt.yaml create mode 100644 artifacthub/library/pod-security-policy/privileged-containers/1.1.2/samples/psp-privileged-container/example_disallowed.yaml create mode 100644 artifacthub/library/pod-security-policy/privileged-containers/1.1.2/samples/psp-privileged-container/update.yaml create mode 100644 artifacthub/library/pod-security-policy/privileged-containers/1.1.2/suite.yaml create mode 100644 artifacthub/library/pod-security-policy/privileged-containers/1.1.2/template.yaml diff --git a/artifacthub/library/pod-security-policy/privileged-containers/1.1.2/artifacthub-pkg.yml b/artifacthub/library/pod-security-policy/privileged-containers/1.1.2/artifacthub-pkg.yml new file mode 100644 index 000000000..1780929e6 --- /dev/null +++ b/artifacthub/library/pod-security-policy/privileged-containers/1.1.2/artifacthub-pkg.yml @@ -0,0 +1,22 @@ +version: 1.1.2 +name: k8spspprivilegedcontainer +displayName: Privileged Container +createdAt: "2024-09-19T20:41:16Z" +description: Controls the ability of any container to enable privileged mode. Corresponds to the `privileged` field in a PodSecurityPolicy. For more information, see https://kubernetes.io/docs/concepts/policy/pod-security-policy/#privileged +digest: c59b8fdc5827901a5d35fb33825275427b6cf27e38d5f2d975ac52fcc022deff +license: Apache-2.0 +homeURL: https://open-policy-agent.github.io/gatekeeper-library/website/privileged-containers +keywords: + - gatekeeper + - open-policy-agent + - policies +readme: |- + # Privileged Container + Controls the ability of any container to enable privileged mode. Corresponds to the `privileged` field in a PodSecurityPolicy. For more information, see https://kubernetes.io/docs/concepts/policy/pod-security-policy/#privileged +install: |- + ### Usage + ```shell + kubectl apply -f https://raw.githubusercontent.com/open-policy-agent/gatekeeper-library/master/artifacthub/library/pod-security-policy/privileged-containers/1.1.2/template.yaml + ``` +provider: + name: Gatekeeper Library diff --git a/artifacthub/library/pod-security-policy/privileged-containers/1.1.2/kustomization.yaml b/artifacthub/library/pod-security-policy/privileged-containers/1.1.2/kustomization.yaml new file mode 100644 index 000000000..7d70d11b7 --- /dev/null +++ b/artifacthub/library/pod-security-policy/privileged-containers/1.1.2/kustomization.yaml @@ -0,0 +1,2 @@ +resources: + - template.yaml diff --git a/artifacthub/library/pod-security-policy/privileged-containers/1.1.2/samples/psp-privileged-container/constraint.yaml b/artifacthub/library/pod-security-policy/privileged-containers/1.1.2/samples/psp-privileged-container/constraint.yaml new file mode 100644 index 000000000..bf2fe519d --- /dev/null +++ b/artifacthub/library/pod-security-policy/privileged-containers/1.1.2/samples/psp-privileged-container/constraint.yaml @@ -0,0 +1,13 @@ +apiVersion: constraints.gatekeeper.sh/v1beta1 +kind: K8sPSPPrivilegedContainer +metadata: + name: psp-privileged-container +spec: + match: + kinds: + - apiGroups: [""] + kinds: ["Pod"] + excludedNamespaces: ["kube-system"] + parameters: + exemptImages: + - "safeimages.com/*" diff --git a/artifacthub/library/pod-security-policy/privileged-containers/1.1.2/samples/psp-privileged-container/disallowed_ephemeral.yaml b/artifacthub/library/pod-security-policy/privileged-containers/1.1.2/samples/psp-privileged-container/disallowed_ephemeral.yaml new file mode 100644 index 000000000..e8c8b9945 --- /dev/null +++ b/artifacthub/library/pod-security-policy/privileged-containers/1.1.2/samples/psp-privileged-container/disallowed_ephemeral.yaml @@ -0,0 +1,12 @@ +apiVersion: v1 +kind: Pod +metadata: + name: nginx-privileged-disallowed + labels: + app: nginx-privileged +spec: + ephemeralContainers: + - name: nginx + image: nginx + securityContext: + privileged: true diff --git a/artifacthub/library/pod-security-policy/privileged-containers/1.1.2/samples/psp-privileged-container/example_allowed.yaml b/artifacthub/library/pod-security-policy/privileged-containers/1.1.2/samples/psp-privileged-container/example_allowed.yaml new file mode 100644 index 000000000..bb65a2c0e --- /dev/null +++ b/artifacthub/library/pod-security-policy/privileged-containers/1.1.2/samples/psp-privileged-container/example_allowed.yaml @@ -0,0 +1,12 @@ +apiVersion: v1 +kind: Pod +metadata: + name: nginx-privileged-allowed + labels: + app: nginx-privileged +spec: + containers: + - name: nginx + image: nginx + securityContext: + privileged: false diff --git a/artifacthub/library/pod-security-policy/privileged-containers/1.1.2/samples/psp-privileged-container/example_allowed_exempt.yaml b/artifacthub/library/pod-security-policy/privileged-containers/1.1.2/samples/psp-privileged-container/example_allowed_exempt.yaml new file mode 100644 index 000000000..782a6036a --- /dev/null +++ b/artifacthub/library/pod-security-policy/privileged-containers/1.1.2/samples/psp-privileged-container/example_allowed_exempt.yaml @@ -0,0 +1,12 @@ +apiVersion: v1 +kind: Pod +metadata: + name: nginx-privileged-allowed-exempt + labels: + app: nginx-privileged +spec: + containers: + - name: nginx + image: safeimages.com/nginx + securityContext: + privileged: true diff --git a/artifacthub/library/pod-security-policy/privileged-containers/1.1.2/samples/psp-privileged-container/example_disallowed.yaml b/artifacthub/library/pod-security-policy/privileged-containers/1.1.2/samples/psp-privileged-container/example_disallowed.yaml new file mode 100644 index 000000000..92353f5b3 --- /dev/null +++ b/artifacthub/library/pod-security-policy/privileged-containers/1.1.2/samples/psp-privileged-container/example_disallowed.yaml @@ -0,0 +1,17 @@ +apiVersion: v1 +kind: Pod +metadata: + name: nginx-privileged-disallowed + labels: + app: nginx-privileged +spec: + containers: + - name: nginx + image: nginx + securityContext: + privileged: true + initContainers: + - name: nginx-init + image: nginx + securityContext: + privileged: true diff --git a/artifacthub/library/pod-security-policy/privileged-containers/1.1.2/samples/psp-privileged-container/update.yaml b/artifacthub/library/pod-security-policy/privileged-containers/1.1.2/samples/psp-privileged-container/update.yaml new file mode 100644 index 000000000..08f36044c --- /dev/null +++ b/artifacthub/library/pod-security-policy/privileged-containers/1.1.2/samples/psp-privileged-container/update.yaml @@ -0,0 +1,17 @@ +kind: AdmissionReview +apiVersion: admission.k8s.io/v1beta1 +request: + operation: "UPDATE" + object: + apiVersion: v1 + kind: Pod + metadata: + name: nginx-privileged-disallowed + labels: + app: nginx-privileged + spec: + containers: + - name: nginx + image: nginx + securityContext: + privileged: true diff --git a/artifacthub/library/pod-security-policy/privileged-containers/1.1.2/suite.yaml b/artifacthub/library/pod-security-policy/privileged-containers/1.1.2/suite.yaml new file mode 100644 index 000000000..3dd4ff863 --- /dev/null +++ b/artifacthub/library/pod-security-policy/privileged-containers/1.1.2/suite.yaml @@ -0,0 +1,29 @@ +kind: Suite +apiVersion: test.gatekeeper.sh/v1alpha1 +metadata: + name: privileged-containers +tests: +- name: privileged-containers-disallowed + template: template.yaml + constraint: samples/psp-privileged-container/constraint.yaml + cases: + - name: example-disallowed + object: samples/psp-privileged-container/example_disallowed.yaml + assertions: + - violations: yes + - name: example-allowed + object: samples/psp-privileged-container/example_allowed.yaml + assertions: + - violations: no + - name: disallowed-ephemeral + object: samples/psp-privileged-container/disallowed_ephemeral.yaml + assertions: + - violations: yes + - name: update + object: samples/psp-privileged-container/update.yaml + assertions: + - violations: no + - name: exempted-image + object: samples/psp-privileged-container/example_allowed_exempt.yaml + assertions: + - violations: no diff --git a/artifacthub/library/pod-security-policy/privileged-containers/1.1.2/template.yaml b/artifacthub/library/pod-security-policy/privileged-containers/1.1.2/template.yaml new file mode 100644 index 000000000..68adef487 --- /dev/null +++ b/artifacthub/library/pod-security-policy/privileged-containers/1.1.2/template.yaml @@ -0,0 +1,129 @@ +apiVersion: templates.gatekeeper.sh/v1 +kind: ConstraintTemplate +metadata: + name: k8spspprivilegedcontainer + annotations: + metadata.gatekeeper.sh/title: "Privileged Container" + metadata.gatekeeper.sh/version: 1.1.2 + description: >- + Controls the ability of any container to enable privileged mode. + Corresponds to the `privileged` field in a PodSecurityPolicy. For more + information, see + https://kubernetes.io/docs/concepts/policy/pod-security-policy/#privileged +spec: + crd: + spec: + names: + kind: K8sPSPPrivilegedContainer + validation: + openAPIV3Schema: + type: object + description: >- + Controls the ability of any container to enable privileged mode. + Corresponds to the `privileged` field in a PodSecurityPolicy. For more + information, see + https://kubernetes.io/docs/concepts/policy/pod-security-policy/#privileged + properties: + exemptImages: + description: >- + Any container that uses an image that matches an entry in this list will be excluded + from enforcement. Prefix-matching can be signified with `*`. For example: `my-image-*`. + + It is recommended that users use the fully-qualified Docker image name (e.g. start with a domain name) + in order to avoid unexpectedly exempting images from an untrusted repository. + type: array + items: + type: string + targets: + - target: admission.k8s.gatekeeper.sh + code: + - engine: K8sNativeValidation + source: + variables: + - name: containers + expression: 'has(variables.anyObject.spec.containers) ? variables.anyObject.spec.containers : []' + - name: initContainers + expression: 'has(variables.anyObject.spec.initContainers) ? variables.anyObject.spec.initContainers : []' + - name: ephemeralContainers + expression: 'has(variables.anyObject.spec.ephemeralContainers) ? variables.anyObject.spec.ephemeralContainers : []' + - name: exemptImagePrefixes + expression: | + !has(variables.params.exemptImages) ? [] : + variables.params.exemptImages.filter(image, image.endsWith("*")).map(image, string(image).replace("*", "")) + - name: exemptImageExplicit + expression: | + !has(variables.params.exemptImages) ? [] : + variables.params.exemptImages.filter(image, !image.endsWith("*")) + - name: exemptImages + expression: | + (variables.containers + variables.initContainers + variables.ephemeralContainers).filter(container, + container.image in variables.exemptImageExplicit || + variables.exemptImagePrefixes.exists(exemption, string(container.image).startsWith(exemption)) + ).map(container, container.image) + - name: badContainers + expression: | + (variables.containers + variables.initContainers + variables.ephemeralContainers).filter(container, + !(container.image in variables.exemptImages) && + (has(container.securityContext) && has(container.securityContext.privileged) && container.securityContext.privileged) + ).map(container, "Privileged container is not allowed: " + container.name +", securityContext.privileged: true") + - name: isUpdate + expression: has(request.operation) && request.operation == "UPDATE" + validations: + - expression: variables.isUpdate || size(variables.badContainers) == 0 + messageExpression: 'variables.badContainers.join(", ")' + - engine: Rego + source: + rego: | + package k8spspprivileged + + import data.lib.exclude_update.is_update + import data.lib.exempt_container.is_exempt + + violation[{"msg": msg, "details": {}}] { + # spec.containers.privileged field is immutable. + not is_update(input.review) + + c := input_containers[_] + not is_exempt(c) + c.securityContext.privileged + msg := sprintf("Privileged container is not allowed: %v, securityContext: %v", [c.name, c.securityContext]) + } + + input_containers[c] { + c := input.review.object.spec.containers[_] + } + + input_containers[c] { + c := input.review.object.spec.initContainers[_] + } + + input_containers[c] { + c := input.review.object.spec.ephemeralContainers[_] + } + libs: + - | + package lib.exclude_update + + is_update(review) { + review.operation == "UPDATE" + } + - | + package lib.exempt_container + + is_exempt(container) { + exempt_images := object.get(object.get(input, "parameters", {}), "exemptImages", []) + img := container.image + exemption := exempt_images[_] + _matches_exemption(img, exemption) + } + + _matches_exemption(img, exemption) { + not endswith(exemption, "*") + exemption == img + } + + _matches_exemption(img, exemption) { + endswith(exemption, "*") + prefix := trim_suffix(exemption, "*") + startswith(img, prefix) + } diff --git a/library/pod-security-policy/privileged-containers/samples/psp-privileged-container/example_disallowed.yaml b/library/pod-security-policy/privileged-containers/samples/psp-privileged-container/example_disallowed.yaml index 936a24f8e..92353f5b3 100644 --- a/library/pod-security-policy/privileged-containers/samples/psp-privileged-container/example_disallowed.yaml +++ b/library/pod-security-policy/privileged-containers/samples/psp-privileged-container/example_disallowed.yaml @@ -10,3 +10,8 @@ spec: image: nginx securityContext: privileged: true + initContainers: + - name: nginx-init + image: nginx + securityContext: + privileged: true diff --git a/library/pod-security-policy/privileged-containers/template.yaml b/library/pod-security-policy/privileged-containers/template.yaml index c5a09674c..68adef487 100644 --- a/library/pod-security-policy/privileged-containers/template.yaml +++ b/library/pod-security-policy/privileged-containers/template.yaml @@ -4,7 +4,7 @@ metadata: name: k8spspprivilegedcontainer annotations: metadata.gatekeeper.sh/title: "Privileged Container" - metadata.gatekeeper.sh/version: 1.1.1 + metadata.gatekeeper.sh/version: 1.1.2 description: >- Controls the ability of any container to enable privileged mode. Corresponds to the `privileged` field in a PodSecurityPolicy. For more @@ -64,13 +64,13 @@ spec: expression: | (variables.containers + variables.initContainers + variables.ephemeralContainers).filter(container, !(container.image in variables.exemptImages) && - (has(container.securityContext) && has(container.securityContext.privileged) && container.securityContext.privileged == true) - ).map(container, "Privileged container is not allowed: " + container.name +", securityContext: " + container.securityContext) + (has(container.securityContext) && has(container.securityContext.privileged) && container.securityContext.privileged) + ).map(container, "Privileged container is not allowed: " + container.name +", securityContext.privileged: true") - name: isUpdate expression: has(request.operation) && request.operation == "UPDATE" validations: - expression: variables.isUpdate || size(variables.badContainers) == 0 - messageExpression: 'variables.badContainers.join("\n")' + messageExpression: 'variables.badContainers.join(", ")' - engine: Rego source: rego: | diff --git a/src/pod-security-policy/privileged-containers/constraint.tmpl b/src/pod-security-policy/privileged-containers/constraint.tmpl index 4711137dd..913a36e98 100644 --- a/src/pod-security-policy/privileged-containers/constraint.tmpl +++ b/src/pod-security-policy/privileged-containers/constraint.tmpl @@ -4,7 +4,7 @@ metadata: name: k8spspprivilegedcontainer annotations: metadata.gatekeeper.sh/title: "Privileged Container" - metadata.gatekeeper.sh/version: 1.1.1 + metadata.gatekeeper.sh/version: 1.1.2 description: >- Controls the ability of any container to enable privileged mode. Corresponds to the `privileged` field in a PodSecurityPolicy. For more diff --git a/src/pod-security-policy/privileged-containers/src.cel b/src/pod-security-policy/privileged-containers/src.cel index b0c77fbc4..5793600ff 100644 --- a/src/pod-security-policy/privileged-containers/src.cel +++ b/src/pod-security-policy/privileged-containers/src.cel @@ -23,10 +23,10 @@ variables: expression: | (variables.containers + variables.initContainers + variables.ephemeralContainers).filter(container, !(container.image in variables.exemptImages) && - (has(container.securityContext) && has(container.securityContext.privileged) && container.securityContext.privileged == true) - ).map(container, "Privileged container is not allowed: " + container.name +", securityContext: " + container.securityContext) + (has(container.securityContext) && has(container.securityContext.privileged) && container.securityContext.privileged) + ).map(container, "Privileged container is not allowed: " + container.name +", securityContext.privileged: true") - name: isUpdate expression: has(request.operation) && request.operation == "UPDATE" validations: - expression: variables.isUpdate || size(variables.badContainers) == 0 - messageExpression: 'variables.badContainers.join("\n")' + messageExpression: 'variables.badContainers.join(", ")' diff --git a/website/docs/validation/privileged-containers.md b/website/docs/validation/privileged-containers.md index 8354c1976..4bbd1fbd3 100644 --- a/website/docs/validation/privileged-containers.md +++ b/website/docs/validation/privileged-containers.md @@ -16,7 +16,7 @@ metadata: name: k8spspprivilegedcontainer annotations: metadata.gatekeeper.sh/title: "Privileged Container" - metadata.gatekeeper.sh/version: 1.1.1 + metadata.gatekeeper.sh/version: 1.1.2 description: >- Controls the ability of any container to enable privileged mode. Corresponds to the `privileged` field in a PodSecurityPolicy. For more @@ -76,13 +76,13 @@ spec: expression: | (variables.containers + variables.initContainers + variables.ephemeralContainers).filter(container, !(container.image in variables.exemptImages) && - (has(container.securityContext) && has(container.securityContext.privileged) && container.securityContext.privileged == true) - ).map(container, "Privileged container is not allowed: " + container.name +", securityContext: " + container.securityContext) + (has(container.securityContext) && has(container.securityContext.privileged) && container.securityContext.privileged) + ).map(container, "Privileged container is not allowed: " + container.name +", securityContext.privileged: true") - name: isUpdate expression: has(request.operation) && request.operation == "UPDATE" validations: - expression: variables.isUpdate || size(variables.badContainers) == 0 - messageExpression: 'variables.badContainers.join("\n")' + messageExpression: 'variables.badContainers.join(", ")' - engine: Rego source: rego: | @@ -194,6 +194,11 @@ spec: image: nginx securityContext: privileged: true + initContainers: + - name: nginx-init + image: nginx + securityContext: + privileged: true ```