feat: add requiresSyncData and verify-sync test #251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I left the template versions as-is given the actual rego/etc hasn't changed, but let me know if we should bump the minor or patch. Thanks! |
maxsmythe
reviewed
Oct 28, 2022
There was a problem hiding this comment.
Basically LGTM. Ideally we'd use more reliable detection for data.inventory usage, but I think requiring it would depend on how much work that entails.
The question around "what about clusters for whom these resources don't exist" is salient if we want to think about the expected uses of these annotations.
|
Also, WRT template versions, leaving them as-is seems right to me (no Rego changes) |
nilekhc
reviewed
Oct 28, 2022
Signed-off-by: Andrew Peabody <andrewpeabody@google.com>
apeabody
requested review from
nilekhc
and removed request for
sozercan and
ritazh
sozercan
reviewed
Nov 4, 2022
sozercan
reviewed
Nov 4, 2022
sozercan
reviewed
Nov 4, 2022
artifacthub/library/general/poddisruptionbudget/1.0.0/template.yaml
Outdated
Show resolved
Hide resolved
sozercan
reviewed
Nov 4, 2022
sozercan
reviewed
Nov 4, 2022
sozercan
reviewed
Nov 4, 2022
|
Pending #255 |
Signed-off-by: Julian Katz <juliankatz@google.com>
Signed-off-by: Andrew Peabody <andrewpeabody@google.com>
Signed-off-by: Andrew Peabody <andrewpeabody@google.com>
Signed-off-by: Andrew Peabody <andrewpeabody@google.com>
sozercan
reviewed
Nov 8, 2022
sozercan
approved these changes
Nov 8, 2022
ritazh
reviewed
Nov 8, 2022
Signed-off-by: Andrew Peabody <andrewpeabody@google.com>
Signed-off-by: Andrew Peabody <andrewpeabody@google.com>
|
Hi Everyone - Is anything else needed before this can be merged? Thanks! |
|
@ritazh any outstanding comments? |
Merged
This was referenced Nov 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
metadata.gatekeeper.sh/requiresSyncDataannotation to templates usingdata.inventorysync.yamlforuniqueingresshosttemplaterequire-synctest which requires templates using data.inventory have both async.yamlandmetadata.gatekeeper.sh/requiresSyncDataannotationFixes #248