-
Notifications
You must be signed in to change notification settings - Fork 320
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: drop excludedNamespaces from sample #364
Conversation
Signed-off-by: Andrew Peabody <andrewpeabody@google.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
The change LGTM!
|
Yeah, my read/thought is this is specific to the Templates themselves, but the sample constraint is published to artifacthub. A slight concern with bumping the Temple version is it might cause end user confusion when there is no actual Template change, however if changes only to sample constraint are limited to patch version bumps that might be minimized. @nilekhc WDYT? Currently the artifacthub CI only considers the template itself for version enforcement. |
@nilekhc thoughts? |
Version chance in the Artifacthub CI is only to enforce version bumping when the template changes. My main concern here is, we update the AH package only when the template changes. So even if we make this change, they won't reflect on AH. Should we update our logic for when to trigger AH refresh? If so what all files should we consider? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What this PR does / why we need it: drop
excludedNamespaces
from sample constraint forK8sBlockLoadBalancer