Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(verifydeprecatedapi): add missing RuntimeClass kind #404

Conversation

shinebayar-g
Copy link
Contributor

What this PR does / why we need it:

RuntimeClass kind is missing from spec.match.kinds resulting in missing validation.

Which issue(s) does this PR fix (optional, using fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when the PR gets merged):
Fixes #

Special notes for your reviewer:

Signed-off-by: Shinebayar Gansukh <3091558+shinebayar-g@users.noreply.github.com>
@shinebayar-g shinebayar-g force-pushed the verifydeprecatedapi-add-missing-kind branch from ef8c8a9 to 37ebf76 Compare September 24, 2023 08:15
Copy link
Contributor

@apeabody apeabody left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution @shinebayar-g!

@apeabody apeabody requested a review from sozercan October 13, 2023 21:15
Copy link
Member

@sozercan sozercan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM

@sozercan sozercan merged commit c6500e3 into open-policy-agent:master Oct 13, 2023
@shinebayar-g shinebayar-g deleted the verifydeprecatedapi-add-missing-kind branch October 13, 2023 23:17
skaven81 pushed a commit to skaven81/gatekeeper-library that referenced this pull request Oct 26, 2023
…agent#404)

Signed-off-by: Shinebayar Gansukh <3091558+shinebayar-g@users.noreply.github.com>
Co-authored-by: Andrew Peabody <andrewpeabody@google.com>
Signed-off-by: Paul Krizak <paul.krizak@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants