Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: skip AdmissionReview in doc generate #412

Merged
merged 6 commits into from
Nov 3, 2023
Merged

chore: skip AdmissionReview in doc generate #412

merged 6 commits into from
Nov 3, 2023

Conversation

apeabody
Copy link
Contributor

What this PR does / why we need it: The AdmissionReview objects aren't really helpful as doc examples, this skips them during the doc generation.

Fixes: #400

Signed-off-by: Andrew Peabody <andrewpeabody@google.com>
Copy link
Contributor

@maxsmythe maxsmythe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@ritazh ritazh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nilekhc fyi

@apeabody apeabody requested a review from a team as a code owner November 3, 2023 19:30
@apeabody apeabody merged commit 7dffd7d into open-policy-agent:master Nov 3, 2023
19 checks passed
@apeabody apeabody deleted the ap-128d branch November 3, 2023 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docs exclude kind: AdmissionReview
4 participants