Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix apiGroups in verify-1.22 example #415

Closed
wants to merge 2 commits into from

Conversation

albert-zhong
Copy link
Contributor

The example for the verifydeprecatedapi-1.22 constraint should say "scheduling.k8s.io" instead of "scheduling.k8s.io/v1beta1" for the apiGroup match kind. Otherwise, the constraint will not properly match the deprecated API resources.

What this PR does / why we need it:

Which issue(s) does this PR fix (optional, using fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when the PR gets merged):
Fixes #

Special notes for your reviewer:

The example for the `verifydeprecatedapi-1.22` constraint should say "scheduling.k8s.io" instead of "scheduling.k8s.io/v1beta1" for the apiGroup match kind. Otherwise, the constraint will not properly match the deprecated API resources.
@nilekhc
Copy link
Contributor

nilekhc commented Oct 9, 2023

@albert-zhong Thanks for the PR. Could you resolve the DCO requirement from the Checks? https://github.com/open-policy-agent/gatekeeper-library/pull/415/checks?check_run_id=17536701222

Also please make changes in the following directory - https://github.com/open-policy-agent/gatekeeper-library/tree/master/library/general/verifydeprecatedapi. Website docs get auto-generated.

@albert-zhong
Copy link
Contributor Author

albert-zhong commented Oct 9, 2023

@albert-zhong Thanks for the PR. Could you resolve the DCO requirement from the Checks? https://github.com/open-policy-agent/gatekeeper-library/pull/415/checks?check_run_id=17536701222

Also please make changes in the following directory - https://github.com/open-policy-agent/gatekeeper-library/tree/master/library/general/verifydeprecatedapi. Website docs get auto-generated.

Thanks! Will do - the fixed PR is here.

@albert-zhong albert-zhong deleted the patch-1 branch October 16, 2023 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants