fix: api groups in constraint 1.22 #416
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Albert Zhong <albert.zhong@databricks.com>
Signed-off-by: Albert Zhong <albert.zhong@databricks.com>
|
Hi @nilekhc , could you take a quick look at this when you have the time? Thanks! |
apeabody
approved these changes
Oct 16, 2023
apeabody
changed the title
skaven81
pushed a commit
to skaven81/gatekeeper-library
that referenced
this pull request
Oct 26, 2023
* fix api groups in constraint 1.22 Signed-off-by: Albert Zhong <albert.zhong@databricks.com> * run make generate generate-website-docs generate-artifacthub-artifacts Signed-off-by: Albert Zhong <albert.zhong@databricks.com> --------- Signed-off-by: Albert Zhong <albert.zhong@databricks.com> Signed-off-by: Paul Krizak <paul.krizak@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
The example for the verifydeprecatedapi-1.22 constraint should say "scheduling.k8s.io" instead of "scheduling.k8s.io/v1beta1" for the apiGroup match kind. Otherwise, the constraint will not properly match the deprecated API resources.
Which issue(s) does this PR fix (optional, using
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when the PR gets merged):Fixes #
Special notes for your reviewer: