Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: clarify template behavior in description #437

Merged
merged 8 commits into from
Dec 6, 2023
Merged

fix: clarify template behavior in description #437

merged 8 commits into from
Dec 6, 2023

Conversation

apeabody
Copy link
Contributor

@apeabody apeabody commented Nov 6, 2023

What this PR does / why we need it: Clarify template behavior in description and move comment to issue #437. If the comment was implemented the new capability would need to be gated with a new parameter to preserve backward compatible behavior anyway.

@apeabody apeabody requested a review from a team as a code owner November 6, 2023 21:07
@apeabody apeabody changed the title clarify template behavior in description fix: clarify template behavior in description Nov 6, 2023
Signed-off-by: Andrew Peabody <andrewpeabody@google.com>
Copy link
Contributor

@maxsmythe maxsmythe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nilekhc nilekhc merged commit bc96399 into master Dec 6, 2023
15 checks passed
@nilekhc nilekhc deleted the ap-asdf23 branch December 6, 2023 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants