Gator cannot test DELETE operations

[skaven81]

What steps did you take and what happened:
I created a test suite that includes an AdmissionReview object of type DELETE:

kind: AdmissionReview
apiVersion: admission.k8s.io/v1beta1
request:
  operation: "DELETE"
  object:
    apiVersion: v1
    kind: Pod
    metadata:
      name: delete
      namespace: default

When executing gator, when it encounters this test case, I get:

    --- FAIL: delete    (0.002s)
        oldObject is nil: For admission webhooks registered for DELETE operations, please use Kubernetes v1.15.0+.

There is no Kubernetes involved, so I suspect that Gator is just linking to an old version of the Kubernetes library that handles admission reviews.

What did you expect to happen:
It should be possible to create Gator test cases that simulate a DELETE operation

Environment:

• Gator version: 3.12

[acpana]

hey @skaven81 thanks for filing this -- admittedly, the err message is not helpful! 🤦🏼

I can change that to indicate that the payload should be part of the oldObject field. So the test AdmissionReview should look like:

kind: AdmissionReview
apiVersion: admission.k8s.io/v1beta1
request:
  operation: "DELETE"
  oldObject:
    apiVersion: v1
    kind: Pod
    metadata:
      name: delete
      namespace: default

And the error message would say operation is DELETE but object is not nil.

I think that would be more helpful, right?

[skaven81]

I see! So gator actually does support testing DELETE operations, but I had a malformed admission review object.

Yes, I agree that a better error message would be great! And perhaps some examples on the Gatekeeper website showing how to construct tests with both AdmissionReview objects as well as concrete resources.