-
Notifications
You must be signed in to change notification settings - Fork 769
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Add sync resource proposal to design docs #2674
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Anlan Du <adu47249@gmail.com>
sozercan
approved these changes
Apr 4, 2023
ritazh
approved these changes
Apr 4, 2023
maxsmythe
approved these changes
Apr 5, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I'd merge but I don't have write access |
Sorry, did the "merge master into commit" step, then got distracted before final merge. |
salaxander
pushed a commit
to salaxander/gatekeeper
that referenced
this pull request
Apr 5, 2023
Signed-off-by: Anlan Du <adu47249@gmail.com> Co-authored-by: Max Smythe <smythe@google.com> Signed-off-by: Xander Grzywinski <xandergr@microsoft.com>
salaxander
pushed a commit
to salaxander/gatekeeper
that referenced
this pull request
Apr 5, 2023
Signed-off-by: Anlan Du <adu47249@gmail.com> Co-authored-by: Max Smythe <smythe@google.com> Signed-off-by: Xander Grzywinski <xandergr@microsoft.com>
davis-haba
pushed a commit
to davis-haba/gatekeeper
that referenced
this pull request
Apr 18, 2023
Signed-off-by: Anlan Du <adu47249@gmail.com> Co-authored-by: Max Smythe <smythe@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it: Sync resource proposal
Which issue(s) this PR fixes (optional, using
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when the PR gets merged):Discussion on #2393
Special notes for your reviewer:
cc @julianKatz