Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add docs about stats #2776

Merged
merged 7 commits into from
May 23, 2023
Merged

Conversation

acpana
Copy link
Contributor

@acpana acpana commented May 16, 2023

PR mostly adds docs for the stats flags added in: #2686

A few other changes:

acpana added 3 commits May 16, 2023 21:55
Signed-off-by: Alex Pana <8968914+acpana@users.noreply.github.com>
Signed-off-by: Alex Pana <8968914+acpana@users.noreply.github.com>
Signed-off-by: Alex Pana <8968914+acpana@users.noreply.github.com>
@codecov-commenter
Copy link

codecov-commenter commented May 16, 2023

Codecov Report

Patch coverage: 87.50% and project coverage change: +0.13 🎉

Comparison is base (a5ebec1) 53.46% compared to head (40d0b2f) 53.60%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2776      +/-   ##
==========================================
+ Coverage   53.46%   53.60%   +0.13%     
==========================================
  Files         127      128       +1     
  Lines       11373    11411      +38     
==========================================
+ Hits         6081     6117      +36     
- Misses       4817     4818       +1     
- Partials      475      476       +1     
Flag Coverage Δ
unittests 53.60% <87.50%> (+0.13%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/audit/manager.go 10.05% <0.00%> (ø)
pkg/syncutil/parser/syncannotationreader.go 91.42% <91.42%> (ø)
pkg/logging/logging.go 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@acpana acpana marked this pull request as ready for review May 17, 2023 00:08
@acpana acpana requested review from maxsmythe, sozercan and ritazh May 17, 2023 00:08
website/docs/metrics.md Outdated Show resolved Hide resolved
website/docs/metrics.md Outdated Show resolved Hide resolved
website/docs/metrics.md Outdated Show resolved Hide resolved
website/docs/metrics.md Outdated Show resolved Hide resolved
acpana and others added 2 commits May 19, 2023 23:19
Signed-off-by: Alex Pana <8968914+acpana@users.noreply.github.com>
Co-authored-by: Rita Zhang <rita.z.zhang@gmail.com>
Signed-off-by: alex <8968914+acpana@users.noreply.github.com>
@acpana acpana requested review from ritazh and maxsmythe May 19, 2023 23:20
Copy link
Contributor

@maxsmythe maxsmythe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Member

@ritazh ritazh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@acpana acpana merged commit 9da7226 into open-policy-agent:master May 23, 2023
Hy3n4 pushed a commit to Hy3n4/gatekeeper that referenced this pull request Jun 30, 2023
Signed-off-by: Alex Pana <8968914+acpana@users.noreply.github.com>
Signed-off-by: alex <8968914+acpana@users.noreply.github.com>
Co-authored-by: Rita Zhang <rita.z.zhang@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants