Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(helm): matchConditions added in Validating & MutatingWebhookConfiguration #3100

Closed
wants to merge 86 commits into from

feat(helm): matchConditions added in Validating & MutatingWebhookConf…

50e0ce7
Select commit
Loading
Failed to load commit list.
Closed

feat(helm): matchConditions added in Validating & MutatingWebhookConfiguration #3100

feat(helm): matchConditions added in Validating & MutatingWebhookConf…
50e0ce7
Select commit
Loading
Failed to load commit list.
DCO / DCO required action Apr 1, 2024 in 1s

DCO

There are 20 commits incorrectly signed off. This means that the author(s) of these commits failed to include a Signed-off-by line in their commit message.

To avoid having PRs blocked in the future, always include Signed-off-by: Author Name <authoremail@example.com> in every commit message. You can also do this automatically by using the -s flag (i.e., git commit -s).

Here is how to fix the problem so that this code can be merged.


Rebase the branch

If you have a local git environment and meet the criteria below, one option is to rebase the branch and add your Signed-off-by lines in the new commits. Please note that if others have already begun work based upon the commits in this branch, this solution will rewrite history and may cause serious issues for collaborators (described in the git documentation under "The Perils of Rebasing").

You should only do this if:

  • You are the only author of the commits in this branch
  • You are absolutely certain nobody else is doing any work based upon this branch
  • There are no empty commits in the branch (for example, a DCO Remediation Commit which was added using --allow-empty)

To add your Signed-off-by line to every commit in this branch:

  1. Ensure you have a local copy of your branch by checking out the pull request locally via command line.
  2. In your local branch, run: git rebase HEAD~86 --signoff
  3. Force push your changes to overwrite the branch: git push --force-with-lease origin master

Summary

Commit sha: 982d3a5, Author: alex, Committer: leewoobin789; Expected "alex 8968914+acpana@users.noreply.github.com", but got "Alex Pana 8968914+acpana@users.noreply.github.com".
Commit sha: d5a4c65, Author: Ben Couture, Committer: leewoobin789; Can not find "Ben Couture bencouture@users.noreply.github.com", in ["Ben Couture Benjamin.Couture@LibertyMutual.com", "Ben Couture bencouture@protonmail.com"].
Commit sha: d390e3c, Author: Dor Bareket, Committer: leewoobin789; Expected "Dor Bareket 42929459+DorB-P@users.noreply.github.com", but got "zapdor2000@gmail.com zapdor2000@gmail.com".
Commit sha: 132500e, Author: James Bruce, Committer: leewoobin789; Expected "James Bruce 127107067+jbruce-nex@users.noreply.github.com", but got "James Bruce james.bruce@ba.com".
Commit sha: 9cf91f9, Author: Jaydipkumar Arvindbhai Gabani, Committer: leewoobin789; Expected "Jaydipkumar Arvindbhai Gabani gabanijaydip@gmail.com", but got "Jaydip Gabani gabanijaydip@gmail.com".
Commit sha: 4c86a8f, Author: Jaydipkumar Arvindbhai Gabani, Committer: leewoobin789; Expected "Jaydipkumar Arvindbhai Gabani gabanijaydip@gmail.com", but got "Jaydip Gabani gabanijaydip@gmail.com".
Commit sha: f3c8613, Author: Jaydipkumar Arvindbhai Gabani, Committer: leewoobin789; Expected "Jaydipkumar Arvindbhai Gabani gabanijaydip@gmail.com", but got "Jaydip Gabani gabanijaydip@gmail.com".
Commit sha: b0fdea4, Author: Jaydipkumar Arvindbhai Gabani, Committer: leewoobin789; Expected "Jaydipkumar Arvindbhai Gabani gabanijaydip@gmail.com", but got "Jaydip Gabani gabanijaydip@gmail.com".
Commit sha: 6a4abac, Author: Jaydipkumar Arvindbhai Gabani, Committer: leewoobin789; Expected "Jaydipkumar Arvindbhai Gabani gabanijaydip@gmail.com", but got "Jaydip Gabani gabanijaydip@gmail.com".
Commit sha: 6f0c3d9, Author: Jaydipkumar Arvindbhai Gabani, Committer: leewoobin789; Expected "Jaydipkumar Arvindbhai Gabani gabanijaydip@gmail.com", but got "Jaydip Gabani gabanijaydip@gmail.com".
Commit sha: 04c97ea, Author: Jaydipkumar Arvindbhai Gabani, Committer: leewoobin789; Expected "Jaydipkumar Arvindbhai Gabani gabanijaydip@gmail.com", but got "Jaydip Gabani gabanijaydip@gmail.com".
Commit sha: d998928, Author: Jaydipkumar Arvindbhai Gabani, Committer: leewoobin789; Expected "Jaydipkumar Arvindbhai Gabani gabanijaydip@gmail.com", but got "Jaydip Gabani gabanijaydip@gmail.com".
Commit sha: 7dc61f8, Author: Sertaç Özercan, Committer: leewoobin789; Expected "Sertaç Özercan 852750+sozercan@users.noreply.github.com", but got "Sertac Ozercan sozercan@gmail.com".
Commit sha: 10802d3, Author: Sertaç Özercan, Committer: leewoobin789; Expected "Sertaç Özercan 852750+sozercan@users.noreply.github.com", but got "Sertac Ozercan sozercan@gmail.com".
Commit sha: 88ecb8c, Author: Sertaç Özercan, Committer: leewoobin789; Expected "Sertaç Özercan 852750+sozercan@users.noreply.github.com", but got "Sertac Ozercan sozercan@gmail.com".
Commit sha: 5a8b71e, Author: Sertaç Özercan, Committer: leewoobin789; Can not find "Sertaç Özercan 852750+sozercan@users.noreply.github.com", in ["Max Smythe smythe@google.com", "Sertac Ozercan sozercan@gmail.com"].
Commit sha: 7b9dd70, Author: Sertaç Özercan, Committer: leewoobin789; Can not find "Sertaç Özercan 852750+sozercan@users.noreply.github.com", in ["dependabot[bot] support@github.com", "Sertac Ozercan sozercan@gmail.com"].
Commit sha: c92d19d, Author: Sertaç Özercan, Committer: leewoobin789; Expected "Sertaç Özercan 852750+sozercan@users.noreply.github.com", but got "Sertac Ozercan sozercan@gmail.com".
Commit sha: dae7514, Author: Sertaç Özercan, Committer: leewoobin789; Expected "Sertaç Özercan 852750+sozercan@users.noreply.github.com", but got "Sertac Ozercan sozercan@gmail.com".
Commit sha: 1dd8ed1, Author: Sertaç Özercan, Committer: leewoobin789; Expected "Sertaç Özercan 852750+sozercan@users.noreply.github.com", but got "Sertac Ozercan sozercan@gmail.com".