chore: update operation generate in deployment yaml and add docs #3738
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jaydip Gabani <gabanijaydip@gmail.com>
ritazh
reviewed
Dec 12, 2024
website/docs/operations.md
Outdated
|
|
||
| __--operation key:__ `generate` | ||
|
|
||
| This operation serves . |
ritazh
reviewed
Dec 12, 2024
website/docs/operations.md
Outdated
| * The ability to create CRDs (unfortunately RBAC doesn't have the syntax to scope this down to just CRDs in the `constraints.gatekeeper.sh` group) | ||
| * The ability to read all `Constraint` resources (members of the group `constraints.gatekeeper.sh`) | ||
| * The ability to read all `ValidatingAdmissionPolicy` objects | ||
| * The ability to read all `ValidatingAdmissionPolicyBinding` objects |
Signed-off-by: Jaydip Gabani <gabanijaydip@gmail.com>
ritazh
reviewed
Dec 12, 2024
|
|
||
| __--operation key:__ `generate` | ||
|
|
||
| This operation enables CRD and VAP/VAPB generation. |
There was a problem hiding this comment.
Suggested change
| This operation enables CRD and VAP/VAPB generation. | |
| This operation enables CRD and VAP/VAPB generation. | |
| To avoid write contention, the Generate operation should be run as a singleton. |
There was a problem hiding this comment.
I think we are missing the operation here: https://github.com/open-policy-agent/gatekeeper/blob/master/manifest_staging/deploy/gatekeeper.yaml#L5084-L5086
There was a problem hiding this comment.
Good catch! I fixed it. Do we want to cut 3.18.1 to update deploy/gatekeeper.yaml?
Signed-off-by: Jaydip Gabani <gabanijaydip@gmail.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3738 +/- ##
==========================================
- Coverage 54.49% 47.54% -6.95%
==========================================
Files 134 236 +102
Lines 12329 19923 +7594
==========================================
+ Hits 6719 9473 +2754
- Misses 5116 9556 +4440
- Partials 494 894 +400
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
ritazh
changed the title
This was referenced Dec 16, 2024
JaydipGabani
added a commit
to JaydipGabani/gatekeeper
that referenced
this pull request
Dec 16, 2024
…n-policy-agent#3738) Signed-off-by: Jaydip Gabani <gabanijaydip@gmail.com> (cherry picked from commit 5471e96)
JaydipGabani
added a commit
that referenced
this pull request
Dec 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, using
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when the PR gets merged):Fixes #
Special notes for your reviewer: