chore: adding FAQs for multi-engine #3761
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jaydip Gabani <gabanijaydip@gmail.com>
ritazh
reviewed
Jan 7, 2025
|
|
||
| <details> | ||
|
|
||
| <summary>Do all engines in a ConstraintTemplate are evaluated? Is there a fallback among engines?</summary> |
There was a problem hiding this comment.
Suggested change
| <summary>Do all engines in a ConstraintTemplate are evaluated? Is there a fallback among engines?</summary> | |
| <summary>Do all engines in a ConstraintTemplate get evaluated? Is there a fallback among engines?</summary> |
ritazh
reviewed
Jan 7, 2025
| <details> | ||
|
|
||
| <summary>Do all engines in a ConstraintTemplate are evaluated? Is there a fallback among engines?</summary> | ||
| Only one engine is evaluated for each ConstraintTemplate. K8sNativeValidation engine hold higher priority than Rego engine. There is no fallback mechanism between engines, hence a logical/syntactical error in policy logic is treated as violation depending on the enforcement action set of the Constraints created for ConstraintTemplate. |
There was a problem hiding this comment.
Suggested change
| Only one engine is evaluated for each ConstraintTemplate. K8sNativeValidation engine hold higher priority than Rego engine. There is no fallback mechanism between engines, hence a logical/syntactical error in policy logic is treated as violation depending on the enforcement action set of the Constraints created for ConstraintTemplate. | |
| Only one engine is evaluated for each ConstraintTemplate. `K8sNativeValidation` engine holds a higher priority than the `Rego` engine. There is no fallback mechanism between engines, hence a logical/syntactical error in the policy logic is treated as violation depending on the enforcement action specified in the Constraint. |
ritazh
reviewed
Jan 7, 2025
|
|
||
| <details> | ||
|
|
||
| <summary>If I have a template with Rego and CEL, which policy logic will be used in evaluating resources?</summary> |
There was a problem hiding this comment.
Suggested change
| <summary>If I have a template with Rego and CEL, which policy logic will be used in evaluating resources?</summary> | |
| <summary>If I have a template with Rego and CEL, which policy engine will be used when evaluating resources?</summary> |
ritazh
reviewed
Jan 7, 2025
|
|
||
| <summary>If I have a template with Rego and CEL, which policy logic will be used in evaluating resources?</summary> | ||
|
|
||
| K8sNativeValidation engine hold higher priority than Rego engine, so with a ConstraintTemplate that has both Rego and CEL. Policy logic written in CEL will get evaluated. |
There was a problem hiding this comment.
Suggested change
| K8sNativeValidation engine hold higher priority than Rego engine, so with a ConstraintTemplate that has both Rego and CEL. Policy logic written in CEL will get evaluated. | |
| K8sNativeValidation engine holds a higher priority than the Rego engine, so with a ConstraintTemplate that has both Rego and CEL. Policy logic written in CEL will get evaluated by the K8sNativeValidation engine. |
ritazh
reviewed
Jan 7, 2025
| <details> | ||
| <summary>Can I change the priority of engines per ConstraintTemplate? | ||
| </summary> | ||
| Engine priority cannot be set per ConstraintTemplate. |
There was a problem hiding this comment.
Suggested change
| Engine priority cannot be set per ConstraintTemplate. | |
| No, engine priority cannot be modified. |
Removing "per ConstraintTemplate" since it makes it look like it can be done but just not per CT.
Signed-off-by: Jaydip Gabani <gabanijaydip@gmail.com>
ritazh
reviewed
Jan 8, 2025
| <details> | ||
|
|
||
| <summary>Do all engines in a ConstraintTemplate get evaluated? Is there a fallback among engines?</summary> | ||
| Only one engine is evaluated for each ConstraintTemplate. `K8sNativeValidation` engine holds a higher priority than the `Rego` engine. There is no fallback mechanism between engines, hence a logical/syntactical error in the policy logic is treated as violation depending on the enforcement action specified in the Constraint. |
There was a problem hiding this comment.
Suggested change
| Only one engine is evaluated for each ConstraintTemplate. `K8sNativeValidation` engine holds a higher priority than the `Rego` engine. There is no fallback mechanism between engines, hence a logical/syntactical error in the policy logic is treated as violation depending on the enforcement action specified in the Constraint. | |
| Only one engine is evaluated for each ConstraintTemplate. The `K8sNativeValidation` engine holds a higher priority than the `Rego` engine. There is no fallback mechanism between engines, hence a logical/syntactical error in the policy logic is treated as a violation depending on the enforcement action specified in the Constraint. |
ritazh
reviewed
Jan 8, 2025
|
|
||
| <summary>If I have a template with Rego and CEL, which policy engine will be used when evaluating resources?</summary> | ||
|
|
||
| K8sNativeValidation engine holds a higher priority than the Rego engine, so with a ConstraintTemplate that has both Rego and CEL. Policy logic written in CEL will get evaluated by the K8sNativeValidation engine. |
There was a problem hiding this comment.
Suggested change
| K8sNativeValidation engine holds a higher priority than the Rego engine, so with a ConstraintTemplate that has both Rego and CEL. Policy logic written in CEL will get evaluated by the K8sNativeValidation engine. | |
| The K8sNativeValidation engine holds a higher priority than the Rego engine. If a ConstraintTemplate has both Rego and CEL, then the policy logic written in CEL will get evaluated by the K8sNativeValidation engine. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, using
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when the PR gets merged):Fixes #
Special notes for your reviewer: