Workflow for main branch that publishes plugin to ghcr.io #80
Conversation
Signed-off-by: Lars Haugan <lars.haugan@sparebank1.no>
Signed-off-by: Lars Haugan <lars.haugan@sparebank1.no>
larhauga
force-pushed
the
gha-workflow-main-publish-ghrc
branch
from
bda7706 to
820faf3
Compare
.github/workflows/main.yaml
Outdated
| @@ -0,0 +1,37 @@ | |||
| name: PR Check | |||
.github/workflows/main.yaml
Outdated
| - name: Check out code | ||
| uses: actions/checkout@v3 | ||
|
|
||
| - name: generate-tag |
There was a problem hiding this comment.
Rather than generating a tag, we could use edge for tracking main. That's how other projects in the OPA or does it.
It would be good if the this flow worked when an actual tag was pushed too, and used that if found.
There was a problem hiding this comment.
What do you mean by using edge here? Are there any good examples in the other projects here?
I can rewrite it to only trigger on tag pushes if that is your preferred way? Like https://github.com/open-policy-agent/opa-envoy-plugin/blob/main/.github/workflows/post-tag.yaml?
Edit: updated the branch with push on tag :)
There was a problem hiding this comment.
Yep! Or https://github.com/open-policy-agent/opa/blob/main/.github/workflows/post-merge.yaml#L139
I.e. use the tag edge for tracking what's currently the top of the main branch. That workflow should run on all pushes to main. Then, ideally we'd have another similar workflow that runs only on pushed tags, and which uses the tag for... well, tagging :)
There was a problem hiding this comment.
Ok, If I understood you correctly, the PR should be updated with two workflows. Does it look OK to you?
Happy to help getting this the way you want 👍
Signed-off-by: Lars Haugan <lars.haugan@sparebank1.no>
Signed-off-by: Lars Haugan <lars.haugan@sparebank1.no>
Hi and again thanks for this project!
Since it seems that the workflow for publishing new versions of the plugins is a manual process, I have added an (untested) github actions workflow that can publish the plugin to ghcr.io.
This will create a somewhat random tag, but will publish on every push to main.
If this is something that you feel is not what you want, feel free to decline this PR :)