pass input to log even if checkrequest times out

Signed-off-by: Rudrakh Panigrahi <rudrakh97@gmail.com>
open-policy-agent · Oct 24, 2023 · 63b3a29 · 63b3a29
1 parent 064d640
commit 63b3a29
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 4 deletions.
diff --git a/internal/internal.go b/internal/internal.go
@@ -384,13 +384,13 @@ func (p *envoyExtAuthzGrpcServer) check(ctx context.Context, req interface{}) (*
 		return nil
 	}
 
-	if ctx.Err() != nil {
-		err = errors.Wrap(ctx.Err(), "check request timed out before query execution")
+	input, err = envoyauth.RequestToInput(req, logger, p.cfg.protoSet, p.cfg.SkipRequestBodyParse)
+	if err != nil {
 		return nil, stop, err
 	}
 
-	input, err = envoyauth.RequestToInput(req, logger, p.cfg.protoSet, p.cfg.SkipRequestBodyParse)
-	if err != nil {
+	if ctx.Err() != nil {
+		err = errors.Wrap(ctx.Err(), "check request timed out before query execution")
 		return nil, stop, err
 	}
 

diff --git a/internal/internal_test.go b/internal/internal_test.go
@@ -520,6 +520,10 @@ func TestCheckContextTimeout(t *testing.T) {
 	if event.Error.Error() != expectedErrMsg {
 		t.Fatalf("Expected error message %v but got %v", expectedErrMsg, event.Error.Error())
 	}
+
+	if len((*event.Input).(map[string]interface{})) == 0 {
+		t.Fatalf("Expected non empty input but got %v", *event.Input)
+	}
 }
 
 func TestCheckIllegalDecisionWithLogger(t *testing.T) {