issue-5230 #455
Closed
issue-5230 #455
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added traceid and spanid to decision log. test for checking traceid in decision log is not passing
added traceid and spanid to decision log. test for checking traceid in decision log is not passing
| info.SpanID = sctx.SpanID().String() | ||
| } | ||
|
|
||
| p.manager.Logger().WithFields(map[string]interface{}{ |
There was a problem hiding this comment.
We should remove this log as much of this is already logged at debug level in the check call. This is also resulting in the test failure.
| @@ -165,6 +167,38 @@ func TestCheckAllow(t *testing.T) { | |||
| } | |||
| } | |||
|
|
|||
| func TestCheckTraceIDInAllowedRequest(t *testing.T) { | |||
There was a problem hiding this comment.
You could use something like this as a reference to setup the unit test.
|
Closing this for now. Feel free to pick this back up and address the comments when you get a chance. Thanks for looking into this. |
|
@ashutosh-narkar , thank you for your patience. I have addressed your comments and created a new PR #462 . Kindly review |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added traceid and spanid to decision log.
test for checking traceid in decision log is not passing