Add traceid to decision logs #462
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added traceid and spanid to decision log. test for checking traceid in decision log is not passing
added traceid and spanid to decision log. test for checking traceid in decision log is not passing
Closed
ashutosh-narkar
force-pushed
the
add-traceid-to-decision-logs
branch
from
3a90821 to
fb90113
Compare
| var found bool | ||
|
|
||
| for _, entry = range consoleLogger.Entries() { | ||
| t.Log(entry.Message) |
There was a problem hiding this comment.
Nit: We probably don't need to log the entry.
| @@ -88,7 +92,7 @@ func TestMain(m *testing.M) { | |||
| resp.body.count == 1 | |||
| }` | |||
| module := fmt.Sprintf(moduleFmt, ts.URL) | |||
| pluginsManager, err := e2e.TestAuthzServerWithWithOpts(module, "envoy/authz/allow", ":9191", plugins.WithTracerProvider(tracerProvider)) | |||
| pluginsManager, err := e2e.TestAuthzServerWithWithOpts(module, "envoy/authz/allow", ":9191", plugins.WithTracerProvider(tracerProvider), plugins.ConsoleLogger(consoleLogger)) | |||
There was a problem hiding this comment.
Do you intend to use the console logger somewhere in this test?
There was a problem hiding this comment.
@ashutosh-narkar , yes.
I'm using it to capture the log entries, identify a decision log in them, and then assert for the presence of trace_id and span_id in the decision log.
see line 155 to 159
|
|
||
| //services := []string{"s1", "s3"} | ||
|
|
||
| m.Register("test_plugin", &testPlugin{}) |
There was a problem hiding this comment.
Can you please help me understand why we're registering this and how we're using it?
There was a problem hiding this comment.
I needed to enable decision_logs .
Looking at
opa-envoy-plugin/envoyauth/evaluation_test.go
Lines 212 to 220 in 064d640
Please suggest if there is any better way.
|
@LionOnTheChase can you please sign your commit. Thanks! |
Signed-off-by: talip <Praneeth.Talishetti@in.pega.com>
Signed-off-by: talip <Praneeth.Talishetti@in.pega.com>
Bumps [docker/setup-buildx-action](https://github.com/docker/setup-buildx-action) from 2 to 3. - [Release notes](https://github.com/docker/setup-buildx-action/releases) - [Commits](docker/setup-buildx-action@v2...v3) --- updated-dependencies: - dependency-name: docker/setup-buildx-action dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [google.golang.org/grpc](https://github.com/grpc/grpc-go) from 1.58.0 to 1.58.1. - [Release notes](https://github.com/grpc/grpc-go/releases) - [Commits](grpc/grpc-go@v1.58.0...v1.58.1) --- updated-dependencies: - dependency-name: google.golang.org/grpc dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [google.golang.org/grpc](https://github.com/grpc/grpc-go) from 1.58.1 to 1.58.2. - [Release notes](https://github.com/grpc/grpc-go/releases) - [Commits](grpc/grpc-go@v1.58.1...v1.58.2) --- updated-dependencies: - dependency-name: google.golang.org/grpc dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: Ashutosh Narkar <anarkar4387@gmail.com>
Bumps [golang.org/x/tools](https://github.com/golang/tools) from 0.13.0 to 0.14.0. - [Release notes](https://github.com/golang/tools/releases) - [Commits](golang/tools@v0.13.0...v0.14.0) --- updated-dependencies: - dependency-name: golang.org/x/tools dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: talip <Praneeth.Talishetti@in.pega.com>
be-a-bee
force-pushed
the
add-traceid-to-decision-logs
branch
from
8fe8254 to
a0badb7
Compare
Closed
|
Closing in favor of #470. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
open-policy-agent/opa#5230
thank you for your patience @ashutosh-narkar . kindly review