Add traceid to decision logs #462
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -8,10 +8,30 @@ import ( | |
| "github.com/open-policy-agent/opa-envoy-plugin/internal" | ||
| "github.com/open-policy-agent/opa-envoy-plugin/plugin" | ||
| "github.com/open-policy-agent/opa/plugins" | ||
| "github.com/open-policy-agent/opa/plugins/logs" | ||
| "github.com/open-policy-agent/opa/storage" | ||
| "github.com/open-policy-agent/opa/storage/inmem" | ||
| ) | ||
|
|
||
| type testPlugin struct { | ||
| events []logs.EventV1 | ||
| } | ||
|
|
||
| func (*testPlugin) Start(context.Context) error { | ||
| return nil | ||
| } | ||
|
|
||
| func (*testPlugin) Stop(context.Context) { | ||
| } | ||
|
|
||
| func (*testPlugin) Reconfigure(context.Context, interface{}) { | ||
| } | ||
|
|
||
| func (p *testPlugin) Log(_ context.Context, event logs.EventV1) error { | ||
| p.events = append(p.events, event) | ||
| return nil | ||
| } | ||
|
|
||
| // TestAuthzServerWithWithOpts creates a new AuthzServer | ||
| // that implements the Envoy ext_authz API. Options for | ||
| // plugins.Manager can/should be customized for the test case. | ||
|
|
@@ -37,6 +57,18 @@ func TestAuthzServerWithWithOpts(module string, path string, addr string, opts . | |
| return nil, err | ||
| } | ||
| m.Register(plugin.PluginName, internal.New(m, cfg)) | ||
|
|
||
| m.Register("test_plugin", &testPlugin{}) | ||
|
There was a problem hiding this comment. Can you please help me understand why we're registering this and how we're using it? There was a problem hiding this comment. I needed to enable decision_logs . Looking at opa-envoy-plugin/envoyauth/evaluation_test.go Lines 212 to 220 in 064d640 Please suggest if there is any better way. |
||
| config, err := logs.ParseConfig([]byte(`{"plugin": "test_plugin"}`), nil, []string{"test_plugin"}) | ||
|
|
||
| if err != nil { | ||
| return nil, err | ||
| } | ||
| config.ConsoleLogs = true | ||
|
|
||
| logPlugin := logs.New(config, m) | ||
| m.Register(logs.Name, logPlugin) | ||
|
|
||
| if err := m.Start(ctx); err != nil { | ||
| return nil, err | ||
| } | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you intend to use the console logger somewhere in this test?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ashutosh-narkar , yes.
I'm using it to capture the log entries, identify a decision log in them, and then assert for the presence of trace_id and span_id in the decision log.
see line 155 to 159