issue-5230 add traceid and spanid to decision log. #473
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 23, 2023
be-a-bee
force-pushed
the
issue_5230_be_a_bee
branch
from
ca830ae to
6df710b
Compare
Closed
internal/internal_test.go
Outdated
| @@ -49,6 +49,8 @@ const exampleAllowedRequest = `{ | |||
| "x-b3-sampled": "1", | |||
| "x-b3-spanid": "537f473f27475073", | |||
| "x-b3-traceid": "537f473f27475073", | |||
| "traceparent" : "00-0000000000000000f7bea0490c3cb268-b9543a567b0289f8-01", | |||
| "tracestate" : "rojo=00f067aa0ba902b7", | |||
There was a problem hiding this comment.
If you're not using this, please remove.
There was a problem hiding this comment.
Hey @be-a-bee just one small comment. We can then merge this. Thanks!
be-a-bee
force-pushed
the
issue_5230_be_a_bee
branch
from
f63ad51 to
9576408
Compare
|
@ashutosh-narkar , thank you. addressed your comment. please review |
| var found bool | ||
|
|
||
| for _, entry = range consoleLogger.Entries() { | ||
| //t.Log(entry.Message) |
There was a problem hiding this comment.
Nit: We should remove this.
There was a problem hiding this comment.
The changes lgtm. Just one small comment. Thanks @be-a-bee!
be-a-bee
force-pushed
the
issue_5230_be_a_bee
branch
from
9576408 to
ce1f034
Compare
|
@ashutosh-narkar , thank you for your prompt response. I addressed it. please take a look |
Signed-off-by: talip <47842333+be-a-bee@users.noreply.github.com> Signed-off-by: Praneeth Talishetti <47842333+be-a-bee@users.noreply.github.com>
ashutosh-narkar
force-pushed
the
issue_5230_be_a_bee
branch
from
ce1f034 to
e0f62a5
Compare
ashutosh-narkar
approved these changes
Oct 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.