Added a counter metric for errors #477
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rudrakhp
force-pushed
the
add_error_counter
branch
2 times, most recently
from
8aca655 to
79ece7f
Compare
srenatus
reviewed
Nov 1, 2023
internal/internal.go
Outdated
| @@ -392,7 +411,7 @@ func (p *envoyExtAuthzGrpcServer) check(ctx context.Context, req interface{}) (* | |||
| } | |||
|
|
|||
| if ctx.Err() != nil { | |||
| err = errors.Wrap(ctx.Err(), "check request timed out before query execution") | |||
| err = errors.Wrap(ctx.Err(), CheckRequestTimeoutErrorMessage) | |||
There was a problem hiding this comment.
[nit] We should introduce our own error type here, and match on that type instead of the error message, please.
There was a problem hiding this comment.
@srenatus Thanks for the comment! I have tried to address this with minimal changes, please do review.
There was a problem hiding this comment.
Thanks! I'll review it tomorrow unless @ashutosh-narkar beats me to it.
rudrakhp
force-pushed
the
add_error_counter
branch
6 times, most recently
from
da9e765 to
c4ae67a
Compare
rudrakhp
force-pushed
the
add_error_counter
branch
from
c4ae67a to
0e5ef44
Compare
There was a problem hiding this comment.
@rudrakhp the changes look good. There seems to be some repetition in the test cases. If we reduce that by moving out common logic, that could be helpful.
rudrakhp
force-pushed
the
add_error_counter
branch
2 times, most recently
from
8797fd3 to
f07838f
Compare
|
Thanks for your comments @ashutosh-narkar ! Addressed them. |
rudrakhp
force-pushed
the
add_error_counter
branch
from
f07838f to
c917678
Compare
Signed-off-by: Rudrakh Panigrahi <rudrakh97@gmail.com>
rudrakhp
force-pushed
the
add_error_counter
branch
from
c917678 to
a0b06fe
Compare
ashutosh-narkar
approved these changes
Nov 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves open-policy-agent/opa#6351