internal: add grpc response timing bucket config #559
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amirsalarsafaei
force-pushed
the
custom-buckets
branch
from
5293f9b to
fade176
Compare
amirsalarsafaei
changed the title
amirsalarsafaei
force-pushed
the
custom-buckets
branch
2 times, most recently
from
33a60ef to
c351554
Compare
|
@ashutosh-narkar, Hi , could you please review this? |
srenatus
approved these changes
Jun 17, 2024
There was a problem hiding this comment.
Thanks! (I'll leave it to @ashutosh-narkar and @johanfylling to merge)
Signed-off-by: Amirsalar Safaei <amirsalar.safaei@divar.ir>
amirsalarsafaei
force-pushed
the
custom-buckets
branch
from
c351554 to
f183f22
Compare
|
Hi @ashutosh-narkar @johanfylling , I would appreciate it if you took a look at this so it doesn’t go stale. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related to open-policy-agent/opa#6814.
adds option for setting custom bucket sizes for grpc response time metric