feat: return query_parameters_to_remove with OkResponse #621
+154
−25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
regeda
force-pushed
the
query-params-to-remove
branch
3 times, most recently
from
fe56692 to
c4cebd5
Compare
SarkanMo-tomtom
approved these changes
Dec 16, 2024
tjons
requested changes
Dec 19, 2024
regeda
force-pushed
the
query-params-to-remove
branch
2 times, most recently
from
171d43f to
8e8160c
Compare
Envoy External Auth v3 API supports the `query_parameters_to_remove` attribute with `OkResponse`. See https://www.envoyproxy.io/docs/envoy/latest/api-v3/service/auth/v3/external_auth.proto#service-auth-v3-okhttpresponse The change allows to return from OPA which query parameters should be removed from the upstream query. Signed-off-by: Anthony Regeda <regedaster@gmail.com>
regeda
force-pushed
the
query-params-to-remove
branch
from
8e8160c to
0bbc900
Compare
|
This looks good to me... we will need to update the docs here: https://github.com/open-policy-agent/opa/blob/main/docs/content/envoy-primer.md#output-document. |
tjons
approved these changes
Dec 31, 2024
regeda
added a commit
to regeda/opa
that referenced
this pull request
Jan 2, 2025
A new attribute `query_parameters_to_remove` has been added. Ref open-policy-agent/opa-envoy-plugin#621
regeda
added a commit
to regeda/opa
that referenced
this pull request
Jan 2, 2025
A new attribute `query_parameters_to_remove` has been added. Ref open-policy-agent/opa-envoy-plugin#621 Signed-off-by: Anthony Regeda <regedaster@gmail.com>
anderseknert
pushed a commit
to regeda/opa
that referenced
this pull request
Jan 3, 2025
A new attribute `query_parameters_to_remove` has been added. Ref open-policy-agent/opa-envoy-plugin#621 Signed-off-by: Anthony Regeda <regedaster@gmail.com>
anderseknert
pushed a commit
to open-policy-agent/opa
that referenced
this pull request
Jan 3, 2025
A new attribute `query_parameters_to_remove` has been added. Ref open-policy-agent/opa-envoy-plugin#621 Signed-off-by: Anthony Regeda <regedaster@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Envoy External Auth v3 API supports the
query_parameters_to_removeattribute withOkResponse.See https://www.envoyproxy.io/docs/envoy/latest/api-v3/service/auth/v3/external_auth.proto#service-auth-v3-okhttpresponse
The change allows to return from OPA which query parameters should be removed from the upstream query.