Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forward incoming HTTP Request ID to remote services when using http.send #5008

Closed
kotyara85 opened this issue Aug 12, 2022 · 8 comments
Closed

Comments

@kotyara85
Copy link

kotyara85 commented Aug 12, 2022

It looks like OPA doesn't honor x-request-id header at this moment
It would be great if it did, because that would give an ability to run E2E traces in case if http.send is involved
Thanks

@srenatus
Copy link
Contributor

Can you please elaborate on your expectations? Should the request ID header become part of the response, or part of the open telemetry spans, or be used in decision logs...? What is you're checking in your E2E traces?

@kotyara85
Copy link
Author

Yeah,
for example:
serviceA -> OPA -> serviceB

serviceA adds x-request-id header
this header would be exposed as reqId in opa info log and passed down to serviceB as x-request-id header

This way you can see one call across all the systems

Thanks

@srenatus
Copy link
Contributor

Ah. So concretely, you're expecting the header to be sent along with http.send calls to remote services.

@kotyara85
Copy link
Author

Ah. So concretely, you're expecting the header to be sent along with http.send calls to remote services.

Yeah

@srenatus srenatus changed the title RequestID Forward incoming HTTP Request ID to remote services when using http.send Aug 12, 2022
@kotyara85
Copy link
Author

@srenatus it would be also beneficial to add reqId to logs

@anderseknert
Copy link
Member

@kotyara85 did you check out the open telemetry integration?

@stale
Copy link

stale bot commented Oct 2, 2022

This issue has been automatically marked as inactive because it has not had any activity in the last 30 days.

@anderseknert
Copy link
Member

With the Open Telemetry support and #5196, I'm not sure this is needed. Let's re-open this if so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants