Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include trace and span identifier in decision logs #5818

Merged

Conversation

ashutosh-narkar
Copy link
Member

Why the changes in this PR are needed?

Currently OPA's decision logs do not include the trace and span identifier associated with a given request handled by the server. This information if available can be helpful to correlate logs and trace data.

What are the changes in this PR?

This change updates the decision log format to now include the trace and span identifier if present.

Fixes: #5230

Currently OPA's decision logs do not include the trace
and span identifier associated with a given request
handled by the server. This information if available
can be helpful to correlate logs and trace data.

This change updates the decision log format to now
include the trace and span identifier if present.

Fixes: open-policy-agent#5230

Signed-off-by: Ashutosh Narkar <anarkar4387@gmail.com>
@netlify
Copy link

netlify bot commented Apr 6, 2023

Deploy Preview for openpolicyagent ready!

Name Link
🔨 Latest commit 7a40a71
🔍 Latest deploy log https://app.netlify.com/sites/openpolicyagent/deploys/642e226ecf740f0008d76fb2
😎 Deploy Preview https://deploy-preview-5818--openpolicyagent.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Contributor

@srenatus srenatus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ashutosh-narkar ashutosh-narkar merged commit 208d324 into open-policy-agent:main Apr 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

include trace.id and span.id in decision logs
2 participants