Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Kernel 5.15.28 and buildroot 2022.02 #4595

Open
wants to merge 4 commits into
base: master-p10
Choose a base branch
from
Open

Kernel 5.15.28 and buildroot 2022.02 #4595

wants to merge 4 commits into from

Conversation

shenki
Copy link
Member

@shenki shenki commented Mar 16, 2022

No description provided.

@shenki
skiboot: Use open-opwer/skiboot.git again
942d534 
By defaulting to BR2_SKIBOOT_CUSTOM_GIT, the custom URL overrode the
default URL for the skiboot repo, forcing the need to have a defualt
custom URL too.

This which was used during internal p10 bring up to force the URL to an
internal repository. There's no need to do it now, and github.com is
moving away from the git:// protocol, so remove the custom default so we
get buildroot's normal URL construction from SKIBOOT_SITE in skiboot.mk.

Overriding the URL can still be done via the defconfig where it is
useful.

Signed-off-by: Joel Stanley <joel@jms.id.au>
@shenki
Kernel 5.15 and buildroot 2022.02
30c6304 
Move to the latest buildroot release, and update all configs to use the
latest LTS kernel release.

The config drops setting of GCC 8 as it is no longer supported. The
default toolchain is now GCC 10.3 and Binutils 2.36.1.

Signed-off-by: Joel Stanley <joel@jms.id.au>
@shenki
Copy link
Member Author

shenki commented Mar 16, 2022

There are a bunch of bugs in hostboot that need fixing before this can be merged.

@shenki
Copy link
Member Author

shenki commented Mar 16, 2022 •
edited
Loading 

../../../../src/include/util/impl/unique_ptr.H: In instantiation of ‘typename std::enable_if<std::is_array<X>::value, decltype (declval<X>()[declval<Index>()])>::type std::unique_ptr<T, Deleter>::operator[](Index) [with Index = int; X = STDUniquePtrTest::practice_struct []; T = STDUniquePtrTest::practice_struct []; Deleter = std::default_delete<STDUniquePtrTest::practice_struct []>; typename std::enable_if<std::is_array<X>::value, decltype (declval<X>()[declval<Index>()])>::type = STDUniquePtrTest::practice_struct&&]’:

./unique_ptr.H:114:16:   required from here
../../../../src/include/util/impl/unique_ptr.H:408:30: error: cannot bind rvalue reference of type ‘std::enable_if<true, STDUniquePtrTest::practice_struct&&>::type’ {aka ‘STDUniquePtrTest::practice_struct&&’} to lvalue of type ‘STDUniquePtrTest::practice_struct’
  408 |                 return iv_ptr[i];
      |                        ~~~~~~^

edit: see this issue open-power/hostboot#204

@op-jenkins
Copy link
Contributor

Can one of the admins verify this patch?

@shenki shenki mentioned this pull request Mar 16, 2022
Open
@IlyaSmirnov91
Copy link

ok to test

@shenki
p10ebmc: Pin to ancient binutils to fix build issues in tracecmd
2df494b 
Signed-off-by: Joel Stanley <joel@jms.id.au>
@shenki
hostboot: Patch to fix GCC 10 errors
2a8ad65 
Signed-off-by: Joel Stanley <joel@jms.id.au>
@shenki shenki force-pushed the kernel-5.15.28-buildroot-2022.02 branch from 946d8dd to 2a8ad65 Compare March 17, 2022 04:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shenki @op-jenkins @IlyaSmirnov91