Fixed the issue for seating the shared mode EC vs VP value. #866
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
common/OpTestHMC.py
Outdated
| int(min_proc_units), 2*int(desired_proc_units), | ||
| 2*int(max_proc_units), min_memory, desired_memory, max_memory)) | ||
| (sharing_mode, min_proc_units, max_proc_units, desired_proc_units, | ||
| int(min_proc_units), overcommit_ratio*int(desired_proc_units), v_max_proc, |
There was a problem hiding this comment.
@SamirMulani we do not need to have overcommit_ratio as a multiplier for min and max (instead of 2 ) as well
There was a problem hiding this comment.
@PraveenPenguin The overcommit_ratio should not be used as a multiplier for the min and max values. For the min, it should be equal to the user input, while for the max, it should either follow stealable count or max v_max_proc value.
|
@SamirMulani please push other changes as well so it has logically conclusion |
added 2 commits
October 1, 2024 14:13
Fix EC Min/Desired Proc Units Calculation and Max Virtual Proc Units Logic Previously, for EC, the `min_proc_units` were calculated by multiplying the user input with the `overcommit_ratio`. This caused an issue where users were unable to set their desired `min_proc_units` for EC. To fix this, the `overcommit_ratio` is no longer used in calculating `desired_proc_units`, as it should only be applied when determining the virtual proc units. The `desired_proc_units`, `max_proc_units` and `min_proc_units` are now set directly based on the user's inputs for EC. Additionally, we added logic to calculate the max virtual proc units by fetching the maximum virtual procs configured in the system. We use this value as the max virtual proc count, but there is a condition where the available stable resource count (multiplied by 2) is compared against the max virtual procs. If the multiplied stable count is greater than the actual max virtual procs retrieved from the HMC command, we use the higher value, otherwise, we proceed with 2 * int(max_proc_units) for EC. Signed-off-by: Samir Mulani <Samir.Mulani@ibm.com>
In the previous implementation, we did not support taking the max_proc_units value from user input. Instead, we first calculated the stealable resources and used that value, with a default setting of max_proc_units=2. Now, we have added the ability to take max_proc_units as input from a configuration file. If the user does not provide this value, we fall back to the stealable resource count. Signed-off-by: Samir Mulani <Samir.Mulani@ibm.com>
SamirMulani
force-pushed
the
shared_mode_fix
branch
from
81aaeab
to
ef9f384
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix EC Min/Desired Proc Units Calculation and Max Virtual Proc Units Logic
Previously, for EC, the
min_proc_unitswere calculated by multiplying the user input with theovercommit_ratio. This caused an issue where users were unable to set their desiredmin_proc_unitsfor EC. To fix this, theovercommit_ratiois no longer used in calculatingdesired_proc_units, as it should only be applied when determining the virtual proc units. Thedesired_proc_units,max_proc_unitsandmin_proc_unitsare now set directly based on the user's inputs for EC.Additionally, we added logic to calculate the max virtual proc units by fetching the maximum virtual procs configured in the system. We use this value as the max virtual proc count, but there is a condition where the available stealable resource count (multiplied by 2) is compared against the max virtual procs. If the multiplied stealable count is greater than the actual max virtual procs retrieved from the HMC command, we use the higher value, otherwise, we proceed with 2 * int(max_proc_units) for EC.