-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Install sosreport package #868
base: master
Are you sure you want to change the base?
Conversation
66cc912
to
875ce7b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Better way is to just add the sos package in this line
op-test/testcases/OpTestLPM.py
Line 141 in 0296a44
lpm_pkg_list = ["src", "rsct.core", "rsct.core.utils", "rsct.basic", "rsct.opt.storagerm", "DynamicRM", "stress-ng"] |
Hi Abdul,
|
yes always better to fail early and it is user responsibility to set the repo and make sure all packages are available with repo.. and make sure we differentiate rhel and suse package |
so you need to handle sos and support both commands |
Install the required packages for collecting sosreport Signed-off-by: Vaishnavi Bhat <vaishnavi@linux.vnet.ibm.com>
875ce7b
to
b3f24dd
Compare
@@ -138,7 +138,7 @@ def check_pkg_installation(self): | |||
pkg_found = True | |||
pkg_notfound = [] | |||
self.oslevel = self.cv_HOST.host_get_OS_Level() | |||
lpm_pkg_list = ["src", "rsct.core", "rsct.core.utils", "rsct.basic", "rsct.opt.storagerm", "DynamicRM", "stress-ng"] | |||
lpm_pkg_list = ["src", "rsct.core", "rsct.core.utils", "rsct.basic", "rsct.opt.storagerm", "DynamicRM", "stress-ng", "sos", "supportutils"] | |||
for pkg in lpm_pkg_list: | |||
pkg_status = self.cv_HOST.host_check_pkg_installed(self.oslevel, pkg) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pkg_status will fail if sos package is not in SUSE OS.. and support in RHEL OS.. so we need to take care explicitly
Install the required packages for collecting sosreport