Revert index commit #100
Closed
Revert index commit #100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Revert change done to avoid double memory allocation for ffdc
data.
Earlier test was done with single proc which worked as expected
but with multiple proc and multiple fork processes trying to
read the ffdc data it is causing double free error and core dump.
Tested:
root@p10bmc:/tmp# busctl tree xyz.openbmc_project.Dump.Manager
`- /xyz
`- /xyz/openbmc_project
`- /xyz/openbmc_project/dump
|- /xyz/openbmc_project/dump/hostboot
| `- /xyz/openbmc_project/dump/hostboot/entry
| |- /xyz/openbmc_project/dump/hostboot/entry/20000001
| |- /xyz/openbmc_project/dump/hostboot/entry/20000002
| |- /xyz/openbmc_project/dump/hostboot/entry/20000003
Signed-off-by: Marri Devender Rao <devenrao@in.ibm.com>
Change-Id: If38be58d9938b476ab39f35e69583fda28522cd4
Signed-off-by: Dhruvaraj Subhashchandran <dhruvaraj@in.ibm.com>
Fixing CI error Conditional jump or move depends on uninitialised value Signed-off-by: Dhruvaraj Subhashchandran <dhruvaraj@in.ibm.com>
In contains_substring_ignoring_case method, if the string that we are looking for is longer than the source string, return with string not found. Earlier the char array index went out of bounds due to invalid arthimetic operation on the index. Tested and found the method working as expected. Signed-off-by: deepakala-k <deepakala.karthikeyan@ibm.com>
The index values of pdbg targets are updated to match the physical device path. So using the index value for getting the scoms shall fail. The fapi position is still connected to the OMI index. So using the fapi position to calculate the instance id in case of DDR4 system. Tested Results: root@p10bmc:/tmp# getscom explorer 08012400 -all explorer k0:n0:s0:p00 0x0000000000000000 explorer k0:n0:s0:p01 0x0000000000000000 explorer k0:n0:s0:p24 0x0000000000000000 explorer k0:n0:s0:p25 0x0000000000000000 explorer k0:n0:s0:p32 0x0000000000000000 explorer k0:n0:s0:p33 0x0000000000000000 explorer k0:n0:s0:p56 0x0000000000000000 explorer k0:n0:s0:p57 0x0000000000000000 /usr/bin/edbg getscom explorer 08012400 -all root@p10bmc:/tmp# getscom explorer 8012810 -all explorer k0:n0:s0:p00 0x8122640700112820 explorer k0:n0:s0:p01 0x8122640700112820 explorer k0:n0:s0:p24 0x8122640700112820 explorer k0:n0:s0:p25 0x8122640700112820 explorer k0:n0:s0:p32 0x8122640700112820 explorer k0:n0:s0:p33 0x8122640700112820 explorer k0:n0:s0:p56 0x8122640700112820 explorer k0:n0:s0:p57 0x8122640700112820 /usr/bin/edbg getscom explorer 8012810 -all
|
Not needed anymore. Using git revert raised another PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.