Adding helper functions for switching of devtree backend in the same process #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Swarnendu-R-C
force-pushed
the
master
branch
2 times, most recently
from
4f6f233
to
4579008
Compare
devenrao
reviewed
May 30, 2023
dhruvibm
reviewed
Jun 25, 2023
Swarnendu-R-C
force-pushed
the
master
branch
4 times, most recently
from
f23a63f
to
d023740
Compare
deepakala-k
reviewed
Jun 28, 2023
deepakala-k
reviewed
Jun 28, 2023
deepakala-k
reviewed
Jun 28, 2023
deepakala-k
reviewed
Jun 28, 2023
Swarnendu-R-C
force-pushed
the
master
branch
4 times, most recently
from
44cb7c3
to
35a7c10
Compare
deepakala-k
approved these changes
Jul 5, 2023
devenrao
reviewed
Jul 12, 2023
devenrao
reviewed
Jul 12, 2023
devenrao
reviewed
Jul 12, 2023
devenrao
reviewed
Jul 12, 2023
devenrao
reviewed
Jul 12, 2023
devenrao
reviewed
Jul 12, 2023
devenrao
reviewed
Jul 12, 2023
Context: It is now required that the devtree backend in BMC systems should be able to switch in the same process on runtime e.g.; from KERNEL to SBEFIFO or vice-versa. This is to support running extract SBE RC hardware procedure. This commit introduces the necessary changes in order to achieve that. Solution: It basically introduces few functions which will clear the pdbg_dt_root and its associated children subsequently if the pdbg_targets_init function is called more than once now (earlier it was not allowed to call pdbg_targets_init function twice in the same process) Test-1: The switching of the backend in the same process was tested through a standalone application which runs in a loop for multiple times and each time it sets the intial backend to SBEFIFO first and then switched it to KERNEL. Trace log is attached along with the PR Test-2: While booting BMC up injected a clock error dueing IPL in between istep0 to istep2 and call the SBR RC extract procedure to get the error code after switching the backend from SBEFIFO to KERNEL. Once the extraction is done switched back to SBEFIFO for further processing. Journal log is attached with the PR. Signed-off-by: swarnendu.roy.chowdhury@ibm.com
Adding Unit test cases for newly added function pdbg_release_dt_root() Signed-off-by: swarnendu.roy.chowdhury@ibm.com
pdbg_targets_init function had a FD leaks issue. This commit fixes that by making sure before it returns it closes all the FDs when it is done
|
Opened the same in a new branch #76 so closing this as not needed anymore |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: It is now required that the devtree backend in BMC systems should be able to switch in the same process on runtime e.g.; from KERNEL to SBEFIFO or vice-versa. This is to support running extract SBE RC hardware procedure. This commit introduces the necessary changes in order to achieve that.
Solution: It basically introduces few functions which will clear the pdbg_dt_root and its associated children subsequently if the pdbg_targets_init function is called more than once now (earlier it was not allowed to call pdbg_targets_init function twice in the same process)
Test-1: The switching of the backend in the same process was tested through a standalone application which runs in a loop for multiple times and each time it sets the intial backend to SBEFIFO first and then switched it to KERNEL. Trace log is attached along with the PR
Test-2: While booting BMC up injected a clock error dueing IPL in between istep0 to istep2 and call the SBR RC extract procedure to get the error code after switching the backend from SBEFIFO to KERNEL. Once the extraction is done switched back to SBEFIFO for further processing. Journal log is attached with the PR.
Signed-off-by: swarnendu.roy.chowdhury@ibm.com
journalLog.txt
TraceLog_KARNEL_First.txt
TraceLog_SBEFIFO_First.txt