get & put scom, getcfam, dump and ffdc support with sbefifo and kernel backend #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Swarnendu-R-C
suggested changes
Dec 7, 2023
devenrao
force-pushed
the
ody
branch
4 times, most recently
from
40e5a3f
to
09ea041
Compare
devenrao
changed the title
devenrao
changed the title
deepakala-k
suggested changes
Dec 13, 2023
devenrao
force-pushed
the
ody
branch
2 times, most recently
from
62630a3
to
a2ec5ba
Compare
deepakala-k
approved these changes
Dec 14, 2023
dhruvibm
reviewed
Dec 14, 2023
devenrao
force-pushed
the
ody
branch
2 times, most recently
from
167e466
to
403e877
Compare
1) Uses the device path configured in the bmc backend device tree to perform get and put scom on odyssey ddr5 chip 2) Checks attribute chip-id of the ocmb target to differentiate between ddr4 and ddr5 ocmb chips for get/put scom 3) For ddr4 ocmb targets parent proc sbefifo device path is used for get/put scom 4) For ddr5 ocmb targets its corresponding sbefifo device path is used for get/put scom Tested: root@ever6bmc:/tmp# getscom odyssey c0002040 -pall odyssey k0:n0:s0:p02 0x0040010002000640 odyssey k0:n0:s0:p03 0x0040010002000640 odyssey k0:n0:s0:p34 0x0040010002000640 odyssey k0:n0:s0:p35 0x0040010002000640 /usr/bin/edbg getscom odyssey c0002040 -pall Change-Id: I2a82812adf32a308dd4695d57548b39955afc31f Signed-off-by: Marri Devender Rao <devenrao@in.ibm.com>
1) Uses the device path configured in the kernel backend device tree to perform get and put scom on odyssey ddr5 chip 2) Checks attribute chip-id of the ocmb target to differentiate between ddr4 and ddr5 ocmb chips for get/put scom 4) For ddr5 ocmb targets its corresponding scom device path is used for get/put scom 4) For cfam i2c target path configured in the backend device tree is used. Tested: test get/putscom 1) At present noticing kernel panic at kernel_pib_getscom method need to debug further. test - getcfam get_ody_fsi_target ocmb_proc 2 ocmb_index 3 kernel_fsi_probe fsi_path set is /i2cr311/slave@00:00/raw get_ody_fsi_target ocmb_proc 2 ocmb_index 3 kernel_fsi_getcfam address 02804 kernel_fsi_getcfam value 010000010 PDBG:fsi_ody_read[383]: rc = 0, addr = 0x02804, data = 0x10000010, target = /hmfsi-ody@311 ody kernel pib read address 0x2804 value 0x10000010 Change-Id: Ia768e375e4a190c328b6fa71ba7bff6a195c26e5 Signed-off-by: Marri Devender Rao <devenrao@in.ibm.com>
1) Modify backend dts file to add fsi targets as they are used as part of getting ffdc 2) Added new chipop for odyssey target which caters for dump and ffdc Tested get_backend_target class_name chipop-ody ocmb_proc 0 ocmb_index 3 get_backend_target class_name fsi-ody ocmb_proc 0 ocmb_index 3 get_backend_target class_name chipop-ody ocmb_proc 0 ocmb_index 3 **sucessfully collected dump data len is 20184 before calling sbe_ody_ffdc_get PDBG:fsi_ody_read[382]: rc = 0, addr = 0x02809, data = 0x9133603f, target = /hmfsi-ody@111 **status of ffdc_get is 0 ffdc_len 0 Signed-off-by: Marri Devender Rao <devenrao@in.ibm.com> Change-Id: Ieb21eef8c18344e9dae5e7f9c7acf0db60eced9e
|
looks good |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.