Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rosdep update before rosdep install #497

Merged
merged 4 commits into from
Jul 17, 2024
Merged

Conversation

arjo129
Copy link
Member

@arjo129 arjo129 commented Jul 15, 2024

I know we ask the user to run rosdep update when they install ros-dev-tools for the first time. However, it probably is a good idea to rosdep update before running rosdep install.

Copy link
Member

@Yadunund Yadunund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Do you mind also updating the instructions to be a bit ROS distro agnostic as suggested?

README.md Outdated Show resolved Hide resolved
@arjo129 arjo129 enabled auto-merge (squash) July 16, 2024 01:45
@arjo129 arjo129 disabled auto-merge July 16, 2024 01:59
@Yadunund Yadunund enabled auto-merge (squash) July 17, 2024 17:49
arjo129 and others added 4 commits July 18, 2024 05:18
I know we ask the user to run `rosdep update` when they install `ros-dev-tools` for the first time. However, it probably is a good idea to `rosdep update` before running `rosdep install`.

Signed-off-by: Arjo Chakravarty <arjoc@intrinsic.ai>
Signed-off-by: Arjo Chakravarty <arjoc@google.com>
Co-authored-by: Yadu <yadunund@intrinsic.ai>
Signed-off-by: Arjo Chakravarty <arjo129@gmail.com>
Signed-off-by: Arjo Chakravarty <arjoc@google.com>
Signed-off-by: Arjo Chakravarty <arjoc@intrinsic.ai>
Signed-off-by: Arjo Chakravarty <arjoc@google.com>
Signed-off-by: Yadunund <yadunund@intrinsic.ai>
Signed-off-by: Arjo Chakravarty <arjoc@google.com>
@Yadunund Yadunund merged commit 100453f into main Jul 17, 2024
2 checks passed
@Yadunund Yadunund deleted the arjo/docs/rosdep_update branch July 17, 2024 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants