From 54f8b6ae1839431efd52e16de830dfc82ffb34ae Mon Sep 17 00:00:00 2001 From: Arjo Chakravarty Date: Mon, 15 Jul 2024 09:34:03 +0800 Subject: [PATCH 1/4] Add `rosdep update` before `rosdep install` I know we ask the user to run `rosdep update` when they install `ros-dev-tools` for the first time. However, it probably is a good idea to `rosdep update` before running `rosdep install`. Signed-off-by: Arjo Chakravarty Signed-off-by: Arjo Chakravarty --- README.md | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/README.md b/README.md index fea3529..f20a4d9 100644 --- a/README.md +++ b/README.md @@ -110,11 +110,12 @@ wget https://raw.githubusercontent.com/open-rmf/rmf/main/rmf.repos vcs import src < rmf.repos ``` -Install dependencies via `rosdep`. +Update your rosdep definitions and install dependencies via `rosdep`. Replace `humble` with ROS 2 distro of your choice. ```bash cd ~/rmf_ws +rosdep update rosdep install --from-paths src --ignore-src --rosdistro humble -y ``` From a5754f67ce956699fec0c7e21c7e1f45ceb68a05 Mon Sep 17 00:00:00 2001 From: Arjo Chakravarty Date: Tue, 16 Jul 2024 09:45:00 +0800 Subject: [PATCH 2/4] Update README.md Co-authored-by: Yadu Signed-off-by: Arjo Chakravarty Signed-off-by: Arjo Chakravarty --- README.md | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/README.md b/README.md index f20a4d9..7241e9d 100644 --- a/README.md +++ b/README.md @@ -116,7 +116,8 @@ Replace `humble` with ROS 2 distro of your choice. ```bash cd ~/rmf_ws rosdep update -rosdep install --from-paths src --ignore-src --rosdistro humble -y +# source your preferred ROS distribution. Eg: `source /opt/ros/rolling/setup.bash` +rosdep install --from-paths src --ignore-src --rosdistro $ROS_DISTRO -y ``` **NOTE: We strongly recommend compiling Open-RMF packages with `clang` as compiler and `lld` as linker.** From 62eec9032fcc3faf855bf8cd971d72b8324fee73 Mon Sep 17 00:00:00 2001 From: Arjo Chakravarty Date: Tue, 16 Jul 2024 17:11:57 +0800 Subject: [PATCH 3/4] Update README.md Signed-off-by: Arjo Chakravarty Signed-off-by: Arjo Chakravarty --- README.md | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/README.md b/README.md index 7241e9d..8547978 100644 --- a/README.md +++ b/README.md @@ -111,10 +111,11 @@ vcs import src < rmf.repos ``` Update your rosdep definitions and install dependencies via `rosdep`. -Replace `humble` with ROS 2 distro of your choice. +Replace `$ROS_DISTRO` with ROS 2 distro of your choice. ```bash cd ~/rmf_ws +sudo apt update rosdep update # source your preferred ROS distribution. Eg: `source /opt/ros/rolling/setup.bash` rosdep install --from-paths src --ignore-src --rosdistro $ROS_DISTRO -y From 0af0e41479588eaab4f25899d2f74c496ea46970 Mon Sep 17 00:00:00 2001 From: Yadunund Date: Thu, 18 Jul 2024 01:48:11 +0800 Subject: [PATCH 4/4] Minor touchup Signed-off-by: Yadunund Signed-off-by: Arjo Chakravarty --- README.md | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/README.md b/README.md index 8547978..479a06c 100644 --- a/README.md +++ b/README.md @@ -111,13 +111,12 @@ vcs import src < rmf.repos ``` Update your rosdep definitions and install dependencies via `rosdep`. -Replace `$ROS_DISTRO` with ROS 2 distro of your choice. ```bash cd ~/rmf_ws sudo apt update rosdep update -# source your preferred ROS distribution. Eg: `source /opt/ros/rolling/setup.bash` +source /opt/ros/humble/setup.bash # replace humble with preferred ROS 2 distro. rosdep install --from-paths src --ignore-src --rosdistro $ROS_DISTRO -y ``` @@ -132,8 +131,6 @@ Compile the workspace after sourcing the ROS 2 distro of choice. ```bash cd ~/rmf_ws -source /opt/ros/humble/setup.bash # replace humble with ROS 2 distro of choice. - export CXX=clang++ export CC=clang colcon build --mixin release lld