-
-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: fixed more sauced items overflow on small devices #148
fix: fixed more sauced items overflow on small devices #148
Conversation
✅ Deploy Preview for opensauced-landing ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Maybe you should add a media query breakpoint (it's an overkill I know) where it starts breaking again (at 290 px) because a few small-screen mobile users might see overflowing text. It's not a must requirement since you fixed most of the problem by removing padding and maintainers should feel free to merge the PR but if this was my website I wouldn't have taken chances: At 310 px (19.375 em) media query breakpoint I would have converted the layout like so: |
I would have done that also, but I'm just taking @bdougie suggestions here Cause I feel like it would have been better if it were flex-col then on sm-screen it can now wrap |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good
Description
This PR includes various updates and fixes. It fixes the issue of sauced items overflowing on small devices. It also updates dependencies such as minimist, ua-parser-js, word-wrap, semver, and decode-uri-component to their latest versions. Additionally, it addresses the mismatched selection color and includes style details.
Generated using OpenSauced.
What type of PR is this? (check all applicable)
Related Tickets & Documents
Fixes #139
Mobile & Desktop Screenshots/Recordings
Added tests?
Added to documentation?
[optional] Are there any post-deployment tasks we need to perform?
[optional] What gif best describes this PR or how it makes you feel?