Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fixed more sauced items overflow on small devices #148

Merged
merged 8 commits into from
Aug 2, 2023

Conversation

dev-phantom
Copy link
Contributor

@dev-phantom dev-phantom commented Jul 29, 2023

Description

This PR includes various updates and fixes. It fixes the issue of sauced items overflowing on small devices. It also updates dependencies such as minimist, ua-parser-js, word-wrap, semver, and decode-uri-component to their latest versions. Additionally, it addresses the mismatched selection color and includes style details.

Generated using OpenSauced.

What type of PR is this? (check all applicable)

  • 🍕 Feature
  • 🐛 Bug Fix
  • 📝 Documentation Update
  • 🎨 Style
  • 🧑‍💻 Code Refactor
  • 🔥 Performance Improvements
  • ✅ Test
  • 🤖 Build
  • 🔁 CI
  • 📦 Chore (Release)
  • ⏩ Revert

Related Tickets & Documents

Fixes #139

Mobile & Desktop Screenshots/Recordings

Screenshot (6)

Added tests?

  • 👍 yes
  • 🙅 no, because they aren't needed
  • 🙋 no, because I need help

Added to documentation?

  • 📜 README.md
  • 📓 docs.opensauced.pizza
  • 🍕 dev.to/opensauced
  • 📕 storybook
  • 🙅 no documentation needed

[optional] Are there any post-deployment tasks we need to perform?

[optional] What gif best describes this PR or how it makes you feel?

@netlify
Copy link

netlify bot commented Jul 29, 2023

Deploy Preview for opensauced-landing ready!

Name Link
🔨 Latest commit 71d92af
🔍 Latest deploy log https://app.netlify.com/sites/opensauced-landing/deploys/64ca472e86f2c000084e2f34
😎 Deploy Preview https://deploy-preview-148--opensauced-landing.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@wasimapinjari
Copy link
Contributor

wasimapinjari commented Jul 29, 2023

Maybe you should add a media query breakpoint (it's an overkill I know) where it starts breaking again (at 290 px) because a few small-screen mobile users might see overflowing text. It's not a must requirement since you fixed most of the problem by removing padding and maintainers should feel free to merge the PR but if this was my website I wouldn't have taken chances:

Screenshot (216)

At 310 px (19.375 em) media query breakpoint I would have converted the layout like so:

Screenshot (201)

@dev-phantom
Copy link
Contributor Author

Maybe you should add a media query breakpoint (it's an overkill I know) where it starts breaking again (at 290px) because a few small-screen mobile users might see overflowing text. It's not a must requirement since you fixed most of the problem by removing padding and maintainers should feel free to merge the PR but if this was my website I wouldn't have taken chances:

Screenshot (216)

At 310px media query breakpoint I would have converted the layout like so:

Screenshot (201)

I would have done that also, but I'm just taking @bdougie suggestions here

Cause I feel like it would have been better if it were flex-col then on sm-screen it can now wrap

Copy link
Member

@bdougie bdougie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@bdougie bdougie merged commit ecb2484 into open-sauced:main Aug 2, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: text overflow on footer
4 participants