Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: fixed text overflow on testimonial #155

Merged
merged 1 commit into from
Aug 3, 2023

Conversation

dev-phantom
Copy link
Contributor

Description

fixed the text overflow on testimonial section

What type of PR is this? (check all applicable)

  • πŸ• Feature
  • πŸ› Bug Fix
  • πŸ“ Documentation Update
  • 🎨 Style
  • πŸ§‘β€πŸ’» Code Refactor
  • πŸ”₯ Performance Improvements
  • βœ… Test
  • πŸ€– Build
  • πŸ” CI
  • πŸ“¦ Chore (Release)
  • ⏩ Revert

Related Tickets & Documents

Fixes #147

Mobile & Desktop Screenshots/Recordings

Screenshot (8)

Added tests?

  • πŸ‘ yes
  • πŸ™… no, because they aren't needed
  • πŸ™‹ no, because I need help

Added to documentation?

  • πŸ“œ README.md
  • πŸ““ docs.opensauced.pizza
  • πŸ• dev.to/opensauced
  • πŸ“• storybook
  • πŸ™… no documentation needed

[optional] Are there any post-deployment tasks we need to perform?

[optional] What gif best describes this PR or how it makes you feel?

@netlify
Copy link

netlify bot commented Aug 2, 2023

βœ… Deploy Preview for opensauced-landing ready!

Name Link
πŸ”¨ Latest commit 936d0be
πŸ” Latest deploy log https://app.netlify.com/sites/opensauced-landing/deploys/64ca88728c1d6d00096dc5d1
😎 Deploy Preview https://deploy-preview-155--opensauced-landing.netlify.app
πŸ“± Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@jpmcb
Copy link
Member

jpmcb commented Aug 2, 2023

Hi @dev-phantom - you have several commits in this PR that have already merged on the main branch. Can you rebase this commit against the main branch? Thanks!!

@dev-phantom
Copy link
Contributor Author

@jpmcb i have fixed it

Copy link

@diivi diivi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before:
image

After:
image

LGTM!

Copy link
Member

@bdougie bdougie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this.

@bdougie bdougie merged commit b92c3d7 into open-sauced:main Aug 3, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: overflowing text and no room for text
4 participants