Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: testimonial twitter link converter #157

Conversation

wasimapinjari
Copy link
Contributor

@wasimapinjari wasimapinjari commented Aug 5, 2023

Description

This PR adds the feature of converting testimonial Twitter username handles to Twitter links

What type of PR is this? (check all applicable)

  • 🍕 Feature

Related Tickets & Documents

Closes #29

Desktop Screenshots

BEFORE

Screenshot (225)

AFTER

Screenshot (224)

Added tests?

  • 🙅 no, because they aren't needed

Added to documentation?

  • 🙅 no documentation needed

@netlify
Copy link

netlify bot commented Aug 5, 2023

Deploy Preview for opensauced-landing ready!

Name Link
🔨 Latest commit 8bc7344
🔍 Latest deploy log https://app.netlify.com/sites/opensauced-landing/deploys/64cde1f8748ad900088c562d
😎 Deploy Preview https://deploy-preview-157--opensauced-landing.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@wasimapinjari wasimapinjari changed the title feature: testimonial twitter link convertor feature: testimonial twitter link converter Aug 5, 2023
@a0m0rajab
Copy link

Looks good for me,
can you just add close #157 in the body of the issue to automatically close the issue?

@wasimapinjari
Copy link
Contributor Author

@a0m0rajab That's the PR number you're referring to, I already mentioned the issue number in PR. Both will get closed automatically once PR is merged.

@a0m0rajab
Copy link

a0m0rajab commented Aug 5, 2023

sorry about the mistake for the PR, you just mentioned the issue without adding a keyword, you need to have a keyword like:
close, fix etc

Here is the related documentation: GitHub docs, linking work with issues

when you link it you will have it added to the issue as well in the development:
image

Similar to this:
image

@wasimapinjari
Copy link
Contributor Author

@a0m0rajab I didn't know that was a thing. Thanks for pointing me to the docs! 😄

@a0m0rajab
Copy link

You are welcome! Looking forward to see how the 100daysofoss challenge will end for you!
Have you thought to share your PRs on the highlights page? https://insights.opensauced.pizza/feed

@wasimapinjari
Copy link
Contributor Author

No, I didn't even know we can do that. I will try adding this one! 🥰

@a0m0rajab
Copy link

Awesome! feel free to add your PRs and enjoy the experience, a blog and issue post is going to arrive soon as well!

@wasimapinjari
Copy link
Contributor Author

There you go! 🎉

Screenshot (226)

@a0m0rajab
Copy link

Thank you for sharing that, I just reacted to it!

Copy link
Member

@bdougie bdougie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for tackling this @wasimapinjari

@bdougie bdougie merged commit 2520bda into open-sauced:main Aug 5, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: Link Twitter handles in the testimonial section
3 participants