Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update twitter icon to X #169

Merged
merged 3 commits into from
Oct 3, 2023
Merged

fix: update twitter icon to X #169

merged 3 commits into from
Oct 3, 2023

Conversation

RitaDee
Copy link
Contributor

@RitaDee RitaDee commented Sep 29, 2023

Description

Update the Twitter logo to a simplified version with a new SVG code.

What type of PR is this? (check all applicable)

  • πŸ• Feature
  • πŸ› Bug Fix
  • πŸ“ Documentation Update
  • 🎨 Style
  • πŸ§‘β€πŸ’» Code Refactor
  • πŸ”₯ Performance Improvements
  • βœ… Test
  • πŸ€– Build
  • πŸ” CI
  • πŸ“¦ Chore (Release)
  • ⏩ Revert

Related Tickets & Documents

Fixes #168

Mobile & Desktop Screenshots/Recordings

Before:
image

After:
Screenshot 2023-09-29 at 14 59 16

Added tests?

  • πŸ‘ yes
  • πŸ™… no, because they aren't needed
  • πŸ™‹ no, because I need help

Added to documentation?

  • πŸ“œ README.md
  • πŸ““ docs.opensauced.pizza
  • πŸ• dev.to/opensauced
  • πŸ“• storybook
  • πŸ™… no documentation needed

[optional] Are there any post-deployment tasks we need to perform?

[optional] What gif best describes this PR or how it makes you feel?

@netlify
Copy link

netlify bot commented Sep 29, 2023

βœ… Deploy Preview for opensauced-landing ready!

Name Link
πŸ”¨ Latest commit 11afa5b
πŸ” Latest deploy log https://app.netlify.com/sites/opensauced-landing/deploys/651c33d94bff8a0008ef9088
😎 Deploy Preview https://deploy-preview-169--opensauced-landing.netlify.app
πŸ“± Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance:
Accessibility:
Best Practices:
SEO:
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@nickytonline nickytonline left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @RitaDee! :shipit:

@RitaDee
Copy link
Contributor Author

RitaDee commented Sep 29, 2023

image

I tried changing the Twitter icon to the X icon on the "About" page, but I suspect it is from the CMS (Sanity Studio). Am I right?

@takanome-dev
Copy link

I tried changing the Twitter icon to the X icon on the "About" page, but I suspect it is from the CMS (Sanity Studio). Am I right?

cc @RitaDee, I think it's here

url: 'https://twitter.com/saucedopen',
icon: TwitterLogoW,
label: 'Twitter',

@bdougie
Copy link
Member

bdougie commented Oct 1, 2023

We can do it directly in the cms after this is merged.

@RitaDee
Copy link
Contributor Author

RitaDee commented Oct 1, 2023

We can do it directly in the cms after this is merged.

Great!

Copy link
Contributor

@OgDev-01 OgDev-01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM πŸ•

@OgDev-01
Copy link
Contributor

OgDev-01 commented Oct 2, 2023

I tried changing the Twitter icon to the X icon on the "About" page, but I suspect it is from the CMS (Sanity Studio). Am I right?

cc @RitaDee, I think it's here

url: 'https://twitter.com/saucedopen',
icon: TwitterLogoW,
label: 'Twitter',

update this and we are good @RitaDee πŸ€—

@RitaDee
Copy link
Contributor Author

RitaDee commented Oct 2, 2023

I tried changing the Twitter icon to the X icon on the "About" page, but I suspect it is from the CMS (Sanity Studio). Am I right?

cc @RitaDee, I think it's here

url: 'https://twitter.com/saucedopen',
icon: TwitterLogoW,
label: 'Twitter',

update this and we are good @RitaDee πŸ€—

I already made the change directly in /public/logo/twitterLogoW.svg:

<svg xmlns="http://www.w3.org/2000/svg" viewBox="0 0 24 24" version="1.1" width="38" height="32" fill="none">
  <path d="M18.244 2.25h3.308l-7.227 8.26 8.502 11.24H16.17l-5.214-6.817L4.99 21.75H1.68l7.73-8.835L1.254 2.25H8.08l4.713 6.231" fill="#FFF9ED" />
</svg>

That can only be directly changed in the CMS. What I changed is the twitterLogoW.svg in the /public/logo folder. So, wherever it is called it displays the the X icon.

@bdougie bdougie merged commit b0c3bd3 into open-sauced:main Oct 3, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Update twitter icon to X
6 participants