-
-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: update twitter icon to X #169
Conversation
β Deploy Preview for opensauced-landing ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @RitaDee!
cc @RitaDee, I think it's here landing-page/components/common/SocialLinks.tsx Lines 15 to 17 in 457c4ac
|
We can do it directly in the cms after this is merged. |
Great! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM π
update this and we are good @RitaDee π€ |
I already made the change directly in /public/logo/twitterLogoW.svg:
That can only be directly changed in the CMS. What I changed is the twitterLogoW.svg in the /public/logo folder. So, wherever it is called it displays the the X icon. |
Description
Update the Twitter logo to a simplified version with a new SVG code.
What type of PR is this? (check all applicable)
Related Tickets & Documents
Fixes #168
Mobile & Desktop Screenshots/Recordings
Before:
After:
Added tests?
Added to documentation?
[optional] Are there any post-deployment tasks we need to perform?
[optional] What gif best describes this PR or how it makes you feel?