Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix:fix the toggle navbar #163

Merged
merged 5 commits into from
Sep 19, 2023
Merged

Conversation

dev-phantom
Copy link
Contributor

@dev-phantom dev-phantom commented Sep 14, 2023

Description

Enhance the landing page navbar with a user-friendly toggle close button for improved navigation and user experience.

What type of PR is this? (check all applicable)

  • 🍕 Feature
  • 🐛 Bug Fix
  • 📝 Documentation Update
  • 🎨 Style
  • 🧑‍💻 Code Refactor
  • 🔥 Performance Improvements
  • ✅ Test
  • 🤖 Build
  • 🔁 CI
  • 📦 Chore (Release)
  • ⏩ Revert

Related Tickets & Documents

Fixes #161

Mobile & Desktop Screenshots/Recordings

Screenshot_20230914-184635

Added tests?

  • 👍 yes
  • 🙅 no, because they aren't needed
  • 🙋 no, because I need help

Added to documentation?

  • 📜 README.md
  • 📓 docs.opensauced.pizza
  • 🍕 dev.to/opensauced
  • 📕 storybook
  • 🙅 no documentation needed

[optional] Are there any post-deployment tasks we need to perform?

[optional] What gif best describes this PR or how it makes you feel?

@netlify
Copy link

netlify bot commented Sep 14, 2023

Deploy Preview for opensauced-landing ready!

Name Link
🔨 Latest commit 7ef06f4
🔍 Latest deploy log https://app.netlify.com/sites/opensauced-landing/deploys/65034408e047fa000859457c
😎 Deploy Preview https://deploy-preview-163--opensauced-landing.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance:
Accessibility:
Best Practices:
SEO:
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@dev-phantom dev-phantom marked this pull request as ready for review September 14, 2023 17:38
@CBID2 CBID2 added the 🐛 bug Something isn't working label Sep 17, 2023
Copy link

@CBID2 CBID2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! :)

@dev-phantom
Copy link
Contributor Author

@bdougie please can i get a review on this

@bdougie
Copy link
Member

bdougie commented Sep 18, 2023

@bdougie please can i get a review on this

Sure. Can you add a PR description as well? 90% of my code review happens on mobile and this PR doesn't have a to. of context.

@dev-phantom
Copy link
Contributor Author

@bdougie please can i get a review on this

Sure. Can you add a PR description as well? 90% of my code review happens on mobile and this PR doesn't have a to. of context.

Ops sorry about that
I've updated the description

@bdougie bdougie merged commit a34fa0e into open-sauced:main Sep 19, 2023
4 checks passed
@dev-phantom
Copy link
Contributor Author

Wow 😳

Funny how I fixed this issue using a mobile phone(termux and acode)🐼

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: no close button
3 participants