Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed typography on changelog to dark mode #254

Merged
merged 3 commits into from
May 1, 2024
Merged

Conversation

isabensusan
Copy link
Member

@isabensusan isabensusan commented Apr 30, 2024

Description

Added prose-invert to the changelog body component to make typography dark mode, and removed previous hacky attempts at making text white.

Related Tickets & Documents

closes #256

Mobile & Desktop Screenshots/Recordings

Before:
Very subtle, but there's links in the text that the user can't see because they are black by default.
image

After:
links and text are visible because of default dark mode theme
image

Steps to QA

  1. Go to https://opensauced.pizza/changelog
  2. Open any changelog item and notice the text is fully readable now

Tier (staff will fill in)

  • Tier 1
  • Tier 2
  • Tier 3
  • [ X] Tier 4

[optional] Are there any post-deployment tasks we need to perform?

[optional] What gif best describes this PR or how it makes you feel?

tired-charles-barkley-gif-by-nba-on-tnt

Copy link

netlify bot commented Apr 30, 2024

Deploy Preview for opensauced-landing ready!

Name Link
🔨 Latest commit 3bc62d6
🔍 Latest deploy log https://app.netlify.com/sites/opensauced-landing/deploys/663239b56f55da00084d6042
😎 Deploy Preview https://deploy-preview-254--opensauced-landing.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 100 (no change from production)
Accessibility: 91 (no change from production)
Best Practices: 92 (no change from production)
SEO: 83 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@nickytonline nickytonline left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@nickytonline
Copy link
Member

@bdougie
Copy link
Member

bdougie commented May 1, 2024

There's some errors related to eslint. See https://app.netlify.com/sites/opensauced-landing/deploys/6630576edf5afe0008bc9070#L101-L634

I looked into this and it was unrelated to this PR. Need to add aria tags to an img

#257

@nickytonline nickytonline merged commit 6dac080 into main May 1, 2024
6 checks passed
@nickytonline nickytonline deleted the link-typography-fix branch May 1, 2024 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Links are not visible on changelog.
4 participants