Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

能否支持 commonjs #62

Closed
hubingkang opened this issue Dec 21, 2023 · 6 comments · Fixed by #63 or #64
Closed

能否支持 commonjs #62

hubingkang opened this issue Dec 21, 2023 · 6 comments · Fixed by #63 or #64
Labels
bug Something isn't working enhancement New feature or request

Comments

@hubingkang
Copy link

No description provided.

@ishiko732
Copy link
Member

https://github.com/ishiko732/ts-fsrs/blob/8a669a4d66f5b58a8c7f251d01e627adea9e2221/package.json#L5
通过rollup编译以后是有common.js,如果在common.js环境下显示找不到的话我这边再排查一下

@ishiko732 ishiko732 added the enhancement New feature or request label Dec 21, 2023
@hubingkang
Copy link
Author

嗯，我在 nest.js 中无法直接引入使用。

@ishiko732 ishiko732 added the bug Something isn't working label Dec 21, 2023
@ishiko732
Copy link
Member

今天有点晚了，明天再看看修复

@ishiko732 ishiko732 mentioned this issue Dec 21, 2023
Merged
@ishiko732
Copy link
Member

已发布新版本：ts-fsrs@3.2.3，麻烦在nest.js试一下咯。
目前next.js 能够正常运行：https://ts-fsrs-demo.vercel.app/

@ishiko732
Copy link
Member

你好，我在nest.js进行了测试，能够正常使用ts-fsrs了 @hubingkang

@hubingkang
Copy link
Author

嗯，最新版本已经正常run了

This was linked to pull requests Dec 23, 2023
Chore/support commonjs #63
Merged
Chore/eslint config #64
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Milestone
No milestone
2 participants
@hubingkang @ishiko732