[chore] update mdatagen (#32499)

This PR pulls in the latest mdatagen that auto-generates goleak package tests. There are still some issues to sort out before being able to use it, but it's mostly there. I've found a few more modules where goleak can be enabled with no additional tests so i've done so as part of this PR Fixes #30483 --------- Signed-off-by: Alex Boten <223565+codeboten@users.noreply.github.com>
open-telemetry · Apr 22, 2024 · 78b852c · 78b852c
1 parent ce2d146
commit 78b852c
Show file tree

Hide file tree

Showing 294 changed files with 1,002 additions and 685 deletions.
diff --git a/Makefile b/Makefile
@@ -259,6 +259,7 @@ docker-telemetrygen:
 generate: install-tools
 	cd ./internal/tools && go install go.opentelemetry.io/collector/cmd/mdatagen
 	$(MAKE) for-all CMD="$(GOCMD) generate ./..."
+	$(MAKE) gofmt
 
 .PHONY: githubgen-install
 githubgen-install:

diff --git a/connector/countconnector/package_test.go → .../countconnector/generated_package_test.go b/connector/countconnector/package_test.go → .../countconnector/generated_package_test.go
diff --git a/connector/datadogconnector/generated_package_test.go b/connector/datadogconnector/generated_package_test.go
diff --git a/connector/datadogconnector/metadata.yaml b/connector/datadogconnector/metadata.yaml
@@ -11,3 +11,5 @@ status:
     emeritus: [gbbr]
 
 tests:
+  goleak:
+    skip: true
diff --git a/...ector/exceptionsconnector/package_test.go → ...ptionsconnector/generated_package_test.go b/...ector/exceptionsconnector/package_test.go → ...ptionsconnector/generated_package_test.go
diff --git a/connector/failoverconnector/package_test.go → ...iloverconnector/generated_package_test.go b/connector/failoverconnector/package_test.go → ...iloverconnector/generated_package_test.go
diff --git a/...tor/grafanacloudconnector/package_test.go → ...acloudconnector/generated_package_test.go b/...tor/grafanacloudconnector/package_test.go → ...acloudconnector/generated_package_test.go
diff --git a/connector/routingconnector/package_test.go → ...outingconnector/generated_package_test.go b/connector/routingconnector/package_test.go → ...outingconnector/generated_package_test.go
diff --git a/...tor/servicegraphconnector/package_test.go → ...egraphconnector/generated_package_test.go b/...tor/servicegraphconnector/package_test.go → ...egraphconnector/generated_package_test.go
diff --git a/...ctor/spanmetricsconnector/package_test.go → ...etricsconnector/generated_package_test.go b/...ctor/spanmetricsconnector/package_test.go → ...etricsconnector/generated_package_test.go
diff --git a/...rter/alertmanagerexporter/package_test.go → ...managerexporter/generated_package_test.go b/...rter/alertmanagerexporter/package_test.go → ...managerexporter/generated_package_test.go
diff --git a/exporter/alibabacloudlogserviceexporter/generated_package_test.go b/exporter/alibabacloudlogserviceexporter/generated_package_test.go
diff --git a/exporter/alibabacloudlogserviceexporter/metadata.yaml b/exporter/alibabacloudlogserviceexporter/metadata.yaml
@@ -13,4 +13,6 @@ tests:
   config:
     endpoint: "http://localhost:0"
     project: "otel-testing"
-    logstore: "otel-data"
+    logstore: "otel-data"
+  goleak:
+    skip: true
diff --git a/exporter/awscloudwatchlogsexporter/generated_package_test.go b/exporter/awscloudwatchlogsexporter/generated_package_test.go
diff --git a/exporter/awscloudwatchlogsexporter/metadata.yaml b/exporter/awscloudwatchlogsexporter/metadata.yaml
@@ -18,3 +18,8 @@ tests:
     retry_on_failure:
       enabled: false
   expect_consumer_error: true
+  goleak:
+    ignore:
+      top:
+        # See https://github.com/census-instrumentation/opencensus-go/issues/1191 for more information.
+        - "go.opencensus.io/stats/view.(*worker).start"
diff --git a/exporter/awscloudwatchlogsexporter/package_test.go b/exporter/awscloudwatchlogsexporter/package_test.go
diff --git a/exporter/awsemfexporter/generated_package_test.go b/exporter/awsemfexporter/generated_package_test.go
diff --git a/exporter/awsemfexporter/metadata.yaml b/exporter/awsemfexporter/metadata.yaml
@@ -14,4 +14,6 @@ tests:
     region: 'us-west-2'
     resource_to_telemetry_conversion:
       enabled: true
-  expect_consumer_error: true
+  expect_consumer_error: true
+  goleak:
+    skip: true
diff --git a/exporter/awskinesisexporter/package_test.go → ...kinesisexporter/generated_package_test.go b/exporter/awskinesisexporter/package_test.go → ...kinesisexporter/generated_package_test.go
diff --git a/...hostmetadata/internal/ecs/package_test.go → ...r/awss3exporter/generated_package_test.go b/...hostmetadata/internal/ecs/package_test.go → ...r/awss3exporter/generated_package_test.go
diff --git a/exporter/awss3exporter/go.mod b/exporter/awss3exporter/go.mod
@@ -14,6 +14,7 @@ require (
 	go.opentelemetry.io/collector/pdata v1.5.1-0.20240419202408-d1e631b61158
 	go.opentelemetry.io/otel/metric v1.25.0
 	go.opentelemetry.io/otel/trace v1.25.0
+	go.uber.org/goleak v1.3.0
 	go.uber.org/multierr v1.11.0
 	go.uber.org/zap v1.27.0
 )

diff --git a/exporter/awsxrayexporter/generated_package_test.go b/exporter/awsxrayexporter/generated_package_test.go
diff --git a/exporter/awsxrayexporter/metadata.yaml b/exporter/awsxrayexporter/metadata.yaml
@@ -12,4 +12,6 @@ status:
 tests:
   config:
     region: 'us-west-2'
-  expect_consumer_error: true
+  expect_consumer_error: true
+  goleak:
+    skip: true
diff --git a/exporter/azuredataexplorerexporter/generated_package_test.go b/exporter/azuredataexplorerexporter/generated_package_test.go
diff --git a/exporter/azuredataexplorerexporter/metadata.yaml b/exporter/azuredataexplorerexporter/metadata.yaml
@@ -16,4 +16,9 @@ tests:
     application_id: "f80da32c-108c-415c-a19e-643f461a677a"
     application_key: "xx-xx-xx-xx"
     tenant_id: "21ff9e36-fbaa-43c8-98ba-00431ea10bc3"
-  skip_lifecycle: true
+  skip_lifecycle: true
+  goleak:
+    ignore:
+      top:
+        # See https://github.com/census-instrumentation/opencensus-go/issues/1191 for more information.
+        - "go.opencensus.io/stats/view.(*worker).start"
diff --git a/exporter/azuredataexplorerexporter/package_test.go b/exporter/azuredataexplorerexporter/package_test.go
diff --git a/exporter/azuremonitorexporter/generated_package_test.go b/exporter/azuremonitorexporter/generated_package_test.go
diff --git a/exporter/azuremonitorexporter/metadata.yaml b/exporter/azuremonitorexporter/metadata.yaml
@@ -13,4 +13,6 @@ tests:
   config:
     connection_string: "InstrumentationKey=00000000-0000-0000-0000-000000000000;IngestionEndpoint=https://ingestion.azuremonitor.com/"
     instrumentation_key: b1cd0778-85fc-4677-a3fa-79d3c23e0efd
-  expect_consumer_error: true
+  expect_consumer_error: true
+  goleak:
+    skip: true
diff --git a/exporter/carbonexporter/package_test.go → .../carbonexporter/generated_package_test.go b/exporter/carbonexporter/package_test.go → .../carbonexporter/generated_package_test.go
diff --git a/exporter/cassandraexporter/package_test.go → ...ssandraexporter/generated_package_test.go b/exporter/cassandraexporter/package_test.go → ...ssandraexporter/generated_package_test.go
diff --git a/exporter/clickhouseexporter/package_test.go → ...ckhouseexporter/generated_package_test.go b/exporter/clickhouseexporter/package_test.go → ...ckhouseexporter/generated_package_test.go
diff --git a/exporter/coralogixexporter/package_test.go → ...ralogixexporter/generated_package_test.go b/exporter/coralogixexporter/package_test.go → ...ralogixexporter/generated_package_test.go
diff --git a/exporter/datadogexporter/generated_package_test.go b/exporter/datadogexporter/generated_package_test.go
diff --git a/exporter/datadogexporter/metadata.yaml b/exporter/datadogexporter/metadata.yaml
@@ -21,4 +21,7 @@ tests:
       enabled: false
     retry_on_failure:
       enabled: false
-  expect_consumer_error: true
+  expect_consumer_error: true
+  goleak:
+    setup: "setupTestMain(m)"
+    skip: true
diff --git a/exporter/datadogexporter/traces_exporter_test.go b/exporter/datadogexporter/traces_exporter_test.go
@@ -30,7 +30,7 @@ import (
 	"github.com/open-telemetry/opentelemetry-collector-contrib/exporter/datadogexporter/internal/testutil"
 )
 
-func TestMain(m *testing.M) {
+func setupTestMain(m *testing.M) {
 	tracelog.SetLogger(&testlogger{})
 	os.Exit(m.Run())
 }

diff --git a/exporter/datasetexporter/generated_package_test.go b/exporter/datasetexporter/generated_package_test.go
diff --git a/exporter/datasetexporter/metadata.yaml b/exporter/datasetexporter/metadata.yaml
@@ -15,3 +15,5 @@ tests:
     dataset_url: https://app.scalyr.com
     api_key: key-minimal
   skip_lifecycle: true
+  goleak:
+    skip: true
diff --git a/...ter/elasticsearchexporter/package_test.go → ...csearchexporter/generated_package_test.go b/...ter/elasticsearchexporter/package_test.go → ...csearchexporter/generated_package_test.go
diff --git a/exporter/fileexporter/generated_package_test.go b/exporter/fileexporter/generated_package_test.go
diff --git a/exporter/fileexporter/metadata.yaml b/exporter/fileexporter/metadata.yaml
@@ -12,4 +12,9 @@ status:
 tests:
   config:
     path: testdata/log.json
-  expect_consumer_error: true
+  expect_consumer_error: true
+  goleak:
+    ignore:
+      top:
+        # Existing issue for leak: https://github.com/natefinch/lumberjack/issues/56
+        - "gopkg.in/natefinch/lumberjack%2ev2.(*Logger).millRun"