-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Azure Resource Logs translator #34830
Add Azure Resource Logs translator #34830
Conversation
…tor-contrib into azureeventhub_otelsc # Conflicts: # receiver/azureeventhubreceiver/go.mod # receiver/azureeventhubreceiver/go.sum
@MikeGoldsmith I would remove the '[user]' from your change log entry and see if it fixes the issue since it says it's the default value anyway. I'll also look into the go mod issue, although I always struggle with those too! |
single quotes around your array makes it a string |
@MikeGoldsmith I submitted a PR to your fork to try and address some of the build issues. |
Thank you @cparkins, I'll take a look shortly. |
…elemetry-collector-contrib into azureeventhub_otelsc
Co-authored-by: Alex Boten <223565+codeboten@users.noreply.github.com>
…elemetry-collector-contrib into azureeventhub_otelsc
Hey @MikeGoldsmith , Sorry for the late reply. It seems i've missed some updates. I believe it would be a good in next step to introduce the possibility to enable corrections to JSON string so that it would be possible to apply semantic conventions translation. We do it unconditionally in our implementation (you can check it in this commit). I agree, It's not the best approach. It worth to add some extra logic to make it optional and keep the There is also another commit with the time convertion approach. I would like to create a PR with these changes for the both |
**Description**: This PR adds a new Azure Resource Logs translator that can be used to convert Azure events into resource logs events using Semantic conventions defined here [here](https://github.com/open-telemetry/semantic-conventions/blob/main/docs/azure/events.md). This supersedes following draft PR by updating it to have the latest semconv: - open-telemetry#32486 *Note*: A follow-up PR will update the Azure receiver to use the new translator. **Testing**: Includes unit tests to verify expected behaviours and data structures. **Documentation**: --- cc @markrendle @lmolkova @TylerHelmuth --------- Signed-off-by: Alex Boten <223565+codeboten@users.noreply.github.com> Co-authored-by: Mark Rendle <mark@rendlelabs.com> Co-authored-by: Alex Boten <223565+codeboten@users.noreply.github.com> Co-authored-by: Curtis Robert <crobert@splunk.com> Co-authored-by: Tyler Helmuth <12352919+TylerHelmuth@users.noreply.github.com>
Description:
This PR adds a new Azure Resource Logs translator that can be used to convert Azure events into resource logs events using Semantic conventions defined here here.
This supersedes following draft PR by updating it to have the latest semconv:
Note: A follow-up PR will update the Azure receiver to use the new translator.
Testing:
Includes unit tests to verify expected behaviours and data structures.
Documentation:
cc @markrendle @lmolkova @TylerHelmuth