Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Combine awsemfexporter and awscloudwatchlogsexporter #6991

Closed
aateeqi opened this issue Jan 3, 2022 · 3 comments
Closed

Combine awsemfexporter and awscloudwatchlogsexporter #6991

aateeqi opened this issue Jan 3, 2022 · 3 comments
Assignees
Labels
closed as inactive comp:aws AWS components comp:aws-cw AWS CW related issues Stale

Comments

@aateeqi
Copy link
Contributor

aateeqi commented Jan 3, 2022

Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]

Currently, the awscloudwatchlogsexporter lacks some core functionality such as automatically creating log/group stream in cloudwatch.
Based on
#4714
#4721

there's a demand for enhancing functionality for awscloudwatchlogsexporter.

Describe the solution you'd like

This can be done by incrementally combining awsemfexporter and awscloudwatchlogsexporter into the awscloudwatchexporter. Not only will it enhance the logsexporter, but also would create more visibility around the emfexporter's role in pushing metrics to cloudwatch as discussed in #3697.

The following outlines the steps intended to combine the 2 exporters, into 1 exporter (awscloudwatchexporter)

  1. Extract the CW logs client from the EMF exporter Extract CWlogs client from EMF exporter and use in Awscloudwatchlogsexporter #6969
  2. Use that client in the CW logs exporter Extract CWlogs client from EMF exporter and use in Awscloudwatchlogsexporter #6969
  3. Use the extracted version of the client in the EMF exporter
  4. Copy the EMF metrics handling to the CW exporter
  5. Mark the EMF exporter as deprecated
  6. Wait some appropriate period of time and Remove the EMF exporter

Diagram for incremental steps to combine EMF and Cloudwatchlogs exporter

Describe alternatives you've considered

Another solution would involve having the 2 exporters completely independent and using separate clients and pushers. The downside of this would be much reused code and a confusing user experience that involves 2 exporters to cloudwatch

Additional context
Add any other context or screenshots about the feature request here.

@anuraaga
Copy link
Contributor

anuraaga commented Jan 4, 2022

I think the title is something like "Share logs pushing logic between emf and logs exporter". Combining would leave us with only one exporter component, which is not the goal

@github-actions
Copy link
Contributor

github-actions bot commented Nov 7, 2022

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

@github-actions github-actions bot added the Stale label Nov 7, 2022
@github-actions
Copy link
Contributor

This issue has been closed as inactive because it has been stale for 120 days with no activity.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Apr 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
closed as inactive comp:aws AWS components comp:aws-cw AWS CW related issues Stale
Projects
None yet
Development

No branches or pull requests

3 participants