[chore] [exporter/awscloudwatchlogs] updated example, added additional notes section, and updated some config descriptions #23820
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
exporter/awscloudwatchlogs
rapphil
reviewed
Jun 28, 2023
rapphil
reviewed
Jun 28, 2023
ZahidMirza95
force-pushed
the
update-cwl-doc
branch
from
eeca39d
to
0d79bd2
Compare
simran029
reviewed
Jun 29, 2023
ZahidMirza95
force-pushed
the
update-cwl-doc
branch
from
0d79bd2
to
64e737f
Compare
ZahidMirza95
force-pushed
the
update-cwl-doc
branch
from
64e737f
to
c28dea8
Compare
ZahidMirza95
changed the title
ZahidMirza95
changed the title
ZahidMirza95
changed the title
|
@astencel-sumo @boostchicken I was wondering if one of you can please add a "Skip Changelog" label to this PR, and also review it if you get a chance? This PR is just updating the documentation for the CloudWatch Logs Exporter, there's no functional changes. |
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
|
Closed as inactive. Feel free to reopen if this PR is still being worked on. |
|
This PR is still valid. @boostchicken could you PTAL? |
|
PR recreated with #26375 to address failures and bad merge in README |
codeboten
pushed a commit
that referenced
this pull request
Sep 6, 2023
**Description:** Recreate #23820 with updates and fixes Original PR body ``` Description: Replaced old example in documentation with a new one. Also clarified some important information for the user, such as the fact that log groups and log streams are created automatically, and that Resource ARNs are not supported. Additionally, updated some descriptions of configs. Link to tracking Issue: #4714 Testing: N/A Documentation: Added a new example in documentation that shows how to configure the Exporter to send EMF Logs Clarified that log group and log stream are automatically created for user Stated Resource ARN isn't supported in the Additional Notes section Updated some descriptions of configs ``` --------- Co-authored-by: Zahid Mirza <zam19@rogers.com> Co-authored-by: bryan-aguilar <46550959+bryan-aguilar@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Replaced old example in documentation with a new one. Also clarified some important information for the user, such as the fact that log groups and log streams are created automatically, and that Resource ARNs are not supported. Additionally, updated some descriptions of configs.
Link to tracking Issue: 4714
Testing: N/A
Documentation: