[chore] Enable goleak for tests failing on opencensus-go #30457
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crobert-1
requested review from
MovieStoreGuy and
andrzej-stencel
as code owners
crobert-1
requested review from
dashpole,
djaglowski,
atoulme,
jmacd,
dmitryax,
fatsheep9146,
jpkrohling,
Aneurysm9,
TylerHelmuth,
codeboten,
mx-psi,
bogdandrutu,
evan-bradley,
jsuereth,
arminru,
songy23 and
bryan-aguilar
as code owners
github-actions
bot
added
cmd/configschema
crobert-1
force-pushed
the
goleak_opencensus
branch
from
cc62605
to
044cae3
Compare
|
Alright, this should be ready to review, apologies again for the size. Refer to this comment for a simple way to ensure the changes are just one file being copied into numerous places. |
fatsheep9146
approved these changes
Jan 25, 2024
dmitryax
approved these changes
Jan 29, 2024
cparkins
pushed a commit
to AmadeusITGroup/opentelemetry-collector-contrib
that referenced
this pull request
Feb 1, 2024
…try#30457) **Description:** This enables `goleak` checks for all packages whose only failure is due to [a known issue](census-instrumentation/opencensus-go#1191) within the `opencensus-go` package. I believe it's safe to ignore for two main reasons: 1. All references that I'm aware of are indirect, the contrib repo isn't directly using the stat's worker functionality. The goroutine is started in the dependency's `init()` so it's not something that we're causing. 2. We're actively moving away from the opencensus dependency, and hope to remove it entirely soon. Relevant issue: open-telemetry/opentelemetry-collector#816. Once this work is complete the ignore will no longer be necessary and we can safely remove it. The only changes in this PR are test related. The same file is being copied into different packages, and then we run `make gotidy`. No functionality has been changed. **Link to tracking Issue:** open-telemetry#30438
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This enables
goleakchecks for all packages whose only failure is due to a known issue within theopencensus-gopackage. I believe it's safe to ignore for two main reasons:init()so it's not something that we're causing.The only changes in this PR are test related. The same file is being copied into different packages, and then we run
make gotidy. No functionality has been changed.Link to tracking Issue:
#30438
Testing:
All added tests are passing.