[receiver/splunkenterprisereceiver] update scope name for consistency #34452
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codeboten
commented
Aug 6, 2024
mwear
reviewed
Aug 6, 2024
There was a problem hiding this comment.
=== FAIL: . TestScraper (0.01s)
scraper_test.go:127:
Error Trace: /home/runner/work/opentelemetry-collector-contrib/opentelemetry-collector-contrib/receiver/splunkenterprisereceiver/scraper_test.go:127
Error: Received unexpected error:
make[2]: *** [../../Makefile.Common:131: test-with-cover] Error 1
make[1]: *** [Makefile:179: receiver/splunkenterprisereceiver] Error 2
the following errors occurred:
- resource "map[]": missing expected scope: otelcol/splunkenterprisereceiver
- resource "map[]": unexpected scope: github.com/open-telemetry/opentelemetry-collector-contrib/receiver/splunkenterprisereceiver
Test: TestScraper
=== FAIL: . TestScraper (re-run 1) (0.01s)
scraper_test.go:127:
Error Trace: /home/runner/work/opentelemetry-collector-contrib/opentelemetry-collector-contrib/receiver/splunkenterprisereceiver/scraper_test.go:127
Error: Received unexpected error:
the following errors occurred:
- resource "map[]": missing expected scope: otelcol/splunkenterprisereceiver
- resource "map[]": unexpected scope: github.com/open-telemetry/opentelemetry-collector-contrib/receiver/splunkenterprisereceiver
Test: TestScraper
codeboten
requested review from
djaglowski,
andrzej-stencel,
crobert-1,
dmitryax,
atoulme,
yurishkuro,
dashpole,
fatsheep9146,
TylerHelmuth,
bogdandrutu,
evan-bradley,
tigrannajaryan,
mx-psi and
songy23
as code owners
Update the scope name for telemetry produced by the splunkenterprisereceiverreceiver from otelcol/splunkenterprisereceiver to github.com/open-telemetry/opentelemetry-collector-contrib/receiver/splunkenterprisereceiverreceiver Part of open-telemetry/opentelemetry-collector#9494 Signed-off-by: Alex Boten <223565+codeboten@users.noreply.github.com>
codeboten
force-pushed
the
codeboten/update-scope-splunkenterprisereceiver
branch
from
6ee9704
to
299df8d
Compare
github-actions
bot
added
cmd/otelcontribcol
github-actions
bot
added
exporter/zipkin
extension/encoding
extension/jaegerremotesampling
extension/observer
extension/opamp
extension/sumologic
internal/metadataproviders
pkg/ottl
pkg/translator/jaeger
pkg/translator/zipkin
processor/k8sattributes
|
Thanks for the review @mwear, fixed the test mentioned in your comment |
shalper2
approved these changes
Aug 7, 2024
crobert-1
approved these changes
Aug 7, 2024
f7o
pushed a commit
to f7o/opentelemetry-collector-contrib
that referenced
this pull request
Sep 12, 2024
…open-telemetry#34452) Update the scope name for telemetry produced by the splunkenterprisereceiverreceiver from otelcol/splunkenterprisereceiver to github.com/open-telemetry/opentelemetry-collector-contrib/receiver/splunkenterprisereceiverreceiver Part of open-telemetry/opentelemetry-collector#9494 --------- Signed-off-by: Alex Boten <223565+codeboten@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the scope name for telemetry produced by the splunkenterprisereceiverreceiver from otelcol/splunkenterprisereceiver to github.com/open-telemetry/opentelemetry-collector-contrib/receiver/splunkenterprisereceiverreceiver
Part of open-telemetry/opentelemetry-collector#9494